search

QuickPay / magento-v2

Open Software License 3.0
5 stars 20 forks source link

Remove backwards compatibility with M2.2 #10

Closed wexo-team closed 3 years ago

wexo-team commented 3 years ago

We have experienced issues with the manual include of the callback class, where the composer class map incorrectly resolved to Magento 2.2 even though we're running 2.3. Magento 2.2 is already EOL for about a year.

The issue manifests itself with failing CSRF validation - in reality it responds with 302 on callbacks and these are then marked in Quickpay as successful.

Example of composer classmap that has resolved wrong:

 'QuickPay\\Gateway\\Controller\\Payment\\Callback' => __DIR__ . '/..' . '/quickpay/magento2/Controller/Payment/CallbackM22.php',

The fix referenced in https://github.com/QuickPay/magento-v2/pull/6 is also included.

CodemakersDK commented 3 years ago

This will have to wait for a while, since at the moment there are multiple shops running this module on M2.2.

wexo-team commented 3 years ago

@CodemakersDK we have experienced the same issue on yet another client today and I can see that https://github.com/QuickPay/magento-v2/pull/12 has experienced the same.

I really urge you to handle this issue, as it must be a priority to make it work for current generations of the software and not just previous ones that has been end of life for a year. Could it be an idea to make a 2.2-only fork or release branch on this repository so you can still handle the old release although the primary release tree will be for the updated versions?

Until all this is handled on the main repository we are maintaining a fork that actually works for 2.3.

CodemakersDK commented 3 years ago

Done as a part of PR #10 .