search

QuickPermissions / QuickPermissions-Kotlin

The most easiest way to handle Android Runtime Permissions in Kotlin
Apache License 2.0
317 stars 40 forks source link

Removing transitive dependencies K4Kotlin and Android Databinding #3

Closed SebastianEngel closed 5 years ago

SebastianEngel commented 6 years ago

When the QuickPermissions-Kotlin library is integrated into app projects, it unfortunately brings transitive dependencies with it, which the using application may not want.

The usage of K4Kotlin automatically introduces another transitive dependency on Android Databinding. Both of these libraries are then forced onto the using app, which also requires adding proguard rules for databinding.

The internal usage of K4Kotlin is very low. All of the usages can easily be replaced with default functionality from the support lib. This pull request does exactly that and so removes both of these dependencies.

kirtan403 commented 6 years ago

@SebastianEngel Thank you so much for the pull request. K4kotlin is pretty lightweight. I will review the changes and its impact. Please allow me some time

SebastianEngel commented 6 years ago

Hi @kirtan403, did you find some time to have a look into it?

carterhudson commented 5 years ago

@kirtan403 I like this library, but I'm going to have to stop using it... You depend on a deprecated Kotlin version that clashes with my up-to-date version, causing compiler errors, not to mention the issues above.

carterhudson commented 5 years ago

Decided to use @SebastianEngel 's commit instead. Please maintain your library.

kirtan403 commented 5 years ago

@SebastianEngel I have merged the changes. Will release the new version soon. Sorry for the delay..

kirtan403 commented 5 years ago

@carterhudson I couldn't get the much time. Sorry about that, I am updating versions now.

kirtan403 commented 5 years ago

@SebastianEngel @carterhudson Release new version 0.3.0 https://github.com/QuickPermissions/QuickPermissions-Kotlin/releases/tag/0.3.0