search

QuickSander / homebridge-mieleathome

Apache License 2.0
37 stars 7 forks source link

Introduce stopping state mapped on finished and cancelled. #9

Closed QuickSander closed 3 years ago

QuickSander commented 3 years ago

Currently the mapping is as follows:

Miele State HomeKit InUse HomeKit Active Displayed in Home
Off = 1 0 0 Off
ProgramSelected = 3 0 1 Starting
WaitingToStart = 4 0 1 Starting
InUse = 5 1 1 Running
Finished = 7 0 1 Starting
Cancelled = 9 0 1 Starting

Finished / Cancelled could be mapped as follows instead:

Miele State HomeKit InUse HomeKit Active Displayed in Home
Off = 1 0 0 Off
ProgramSelected = 3 0 1 Starting
WaitingToStart = 4 0 1 Starting
InUse = 5 1 1 Running
Finished = 7 1 0 Stopping
Cancelled = 9 1 0 Stopping

@MichelRabozee Would this be an improvement, or would it break your automation possibilities?

Originally posted by @QuickSander in https://github.com/QuickSander/homebridge-mieleathome/discussions/8

MichelRabozee commented 3 years ago

Hi, as I wrote earlier in the #8, no problem with automation (in Eve, you can act both on inUse and active), hence having it like the new mapping should be an improvement.

QuickSander commented 3 years ago

:tada: This issue has been resolved in version 2.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

MichelRabozee commented 3 years ago

Just a feedback: this logic works perfectly !!!