QuickShop-Community / QuickShop-Hikari

QuickShop is a shop plugin that allows players to easily sell/buy any items from a chest without any commands. In fact, none of the commands that QuickShop provides are ever needed by a player.
https://modrinth.com/plugin/quickshop-hikari
Other
91 stars 56 forks source link

[BUG] FabledSkyblock integration #1631

Closed Sh3r1ffCZ closed 2 months ago

Sh3r1ffCZ commented 4 months ago

Description

Hello, the reason I marked this as a bug is because "QuickShop-Reremake" had an integration option for the FabledSkyblock plugin. I had to switch to the new shop "QuickShop-Hikari", which unfortunately does not have this. The problem is that players can create shops on foreign islands and then the island owner can't enter them. These "their" shops can also be bought out, so they can actually rob that player as well.

Would it be possible to add the integration that this plugin previously had? I wouldn't want to change the whole Skyblock plugin or shop plugin because of this. Thank you very much

Steps to reproduce

Anyone can set up shop on a foreign island

Expected Behaviour

Old Reremake Config:

FabledSkyblock Integration

fabledskyblock:

If a player wants to create a shop, the player must have the quickshop-create flag.

If a player wants to trade a shop, the player must have the quickshop-trade flag.

enable: true

Should we prevent the creation of a shop or trade with a shop outside FabledSkyblock's area?

whitelist-mode: false create:

Screenshots

image

/quickshop paste URL

https://ghost-chu.github.io/quickshop-hikari-paste-viewer/?remote=https%3A%2F%2Fbytebin.lucko.me%2FHlyKSkH2bd

Additional Context

No response

Checklist

creatorfromhell commented 4 months ago

Description

Hello, the reason I marked this as a bug is because "QuickShop-Reremake" had an integration option for the FabledSkyblock plugin. I had to switch to the new shop "QuickShop-Hikari", which unfortunately does not have this. The problem is that players can create shops on foreign islands and then the island owner can't enter them. These "their" shops can also be bought out, so they can actually rob that player as well.

Would it be possible to add the integration that this plugin previously had? I wouldn't want to change the whole Skyblock plugin or shop plugin because of this. Thank you very much

Steps to reproduce

Anyone can set up shop on a foreign island

Expected Behaviour

Old Reremake Config:

FabledSkyblock Integration fabledskyblock:

If a player wants to create a shop, the player must have the quickshop-create flag.

If a player wants to trade a shop, the player must have the quickshop-trade flag.

enable: true #Should we prevent the creation of a shop or trade with a shop outside FabledSkyblock's area? whitelist-mode: false create:

  • MEMBER
  • OWNER
  • OPERATOR
  • COOP

Screenshots

image

/quickshop paste URL

https://ghost-chu.github.io/quickshop-hikari-paste-viewer/?remote=https%3A%2F%2Fbytebin.lucko.me%2FHlyKSkH2bd

Additional Context

No response

Checklist

  • [x] I'm running Paper or Spigot, and not a fork
  • [x] I confirm that Paper/Spigot has been updated to the latest build
  • [x] I confirm that QuickShop-Hikari has been updated to the latest stable version released on Modrinth (or the latest CI version)
  • [ ] I confirm that I have not read these checkboxes and therefore I just ticked them all.
  • [x] I confirm that I'm using QuickShop-Hikari, not QuickShop-Reremake, and I'm well aware that they're maintained by different people, and that Reremake issues shouldn't be reported here.
  • [x] I confirm that I am running a server that is not a Hybird Server, (e.g. Mohist, Magma, CatServer, Banner, etc.), and I am aware that QuickShop-Hikari may not function properly on a Forge/Fabric hybrid server, and I am running at my own risk on such a server program, and I am aware that the I run such server-side programs at my own risk and know that I will not receive any support or help for this behavior.
  • [x] I am well aware that if the Issue Ticket is not filled out correctly and completely, it will simply be closed without any response or reason.

Link to plugin?

Sh3r1ffCZ commented 4 months ago

Description

Hello, the reason I marked this as a bug is because "QuickShop-Reremake" had an integration option for the FabledSkyblock plugin. I had to switch to the new shop "QuickShop-Hikari", which unfortunately does not have this. The problem is that players can create shops on foreign islands and then the island owner can't enter them. These "their" shops can also be bought out, so they can actually rob that player as well. Would it be possible to add the integration that this plugin previously had? I wouldn't want to change the whole Skyblock plugin or shop plugin because of this. Thank you very much

Steps to reproduce

Anyone can set up shop on a foreign island

Expected Behaviour

Old Reremake Config:

FabledSkyblock Integration fabledskyblock:

If a player wants to create a shop, the player must have the quickshop-create flag.

If a player wants to trade a shop, the player must have the quickshop-trade flag.

enable: true #Should we prevent the creation of a shop or trade with a shop outside FabledSkyblock's area? whitelist-mode: false create:

  • MEMBER
  • OWNER
  • OPERATOR
  • COOP

Screenshots

image

/quickshop paste URL

https://ghost-chu.github.io/quickshop-hikari-paste-viewer/?remote=https%3A%2F%2Fbytebin.lucko.me%2FHlyKSkH2bd

Additional Context

No response

Checklist

  • [x] I'm running Paper or Spigot, and not a fork
  • [x] I confirm that Paper/Spigot has been updated to the latest build
  • [x] I confirm that QuickShop-Hikari has been updated to the latest stable version released on Modrinth (or the latest CI version)
  • [ ] I confirm that I have not read these checkboxes and therefore I just ticked them all.
  • [x] I confirm that I'm using QuickShop-Hikari, not QuickShop-Reremake, and I'm well aware that they're maintained by different people, and that Reremake issues shouldn't be reported here.
  • [x] I confirm that I am running a server that is not a Hybird Server, (e.g. Mohist, Magma, CatServer, Banner, etc.), and I am aware that QuickShop-Hikari may not function properly on a Forge/Fabric hybrid server, and I am running at my own risk on such a server program, and I am aware that the I run such server-side programs at my own risk and know that I will not receive any support or help for this behavior.
  • [x] I am well aware that if the Issue Ticket is not filled out correctly and completely, it will simply be closed without any response or reason.

Link to plugin?

Old plugin: https://www.spigotmc.org/resources/quickshop-reremake-1-20-2-ready-multi-currency.62575/

Plugin I switched to: https://www.spigotmc.org/resources/quickshop-hikari-a-powerful-user-friendly-and-relieable-chestshop-plugin-1-18-2-1-21.100125/

creatorfromhell commented 4 months ago

Description

Hello, the reason I marked this as a bug is because "QuickShop-Reremake" had an integration option for the FabledSkyblock plugin. I had to switch to the new shop "QuickShop-Hikari", which unfortunately does not have this. The problem is that players can create shops on foreign islands and then the island owner can't enter them. These "their" shops can also be bought out, so they can actually rob that player as well. Would it be possible to add the integration that this plugin previously had? I wouldn't want to change the whole Skyblock plugin or shop plugin because of this. Thank you very much

Steps to reproduce

Anyone can set up shop on a foreign island

Expected Behaviour

Old Reremake Config:

FabledSkyblock Integration fabledskyblock:

If a player wants to create a shop, the player must have the quickshop-create flag.

If a player wants to trade a shop, the player must have the quickshop-trade flag.

enable: true #Should we prevent the creation of a shop or trade with a shop outside FabledSkyblock's area? whitelist-mode: false create:

  • MEMBER
  • OWNER
  • OPERATOR
  • COOP

Screenshots

image

/quickshop paste URL

https://ghost-chu.github.io/quickshop-hikari-paste-viewer/?remote=https%3A%2F%2Fbytebin.lucko.me%2FHlyKSkH2bd

Additional Context

No response

Checklist

  • [x] I'm running Paper or Spigot, and not a fork
  • [x] I confirm that Paper/Spigot has been updated to the latest build
  • [x] I confirm that QuickShop-Hikari has been updated to the latest stable version released on Modrinth (or the latest CI version)
  • [ ] I confirm that I have not read these checkboxes and therefore I just ticked them all.
  • [x] I confirm that I'm using QuickShop-Hikari, not QuickShop-Reremake, and I'm well aware that they're maintained by different people, and that Reremake issues shouldn't be reported here.
  • [x] I confirm that I am running a server that is not a Hybird Server, (e.g. Mohist, Magma, CatServer, Banner, etc.), and I am aware that QuickShop-Hikari may not function properly on a Forge/Fabric hybrid server, and I am running at my own risk on such a server program, and I am aware that the I run such server-side programs at my own risk and know that I will not receive any support or help for this behavior.
  • [x] I am well aware that if the Issue Ticket is not filled out correctly and completely, it will simply be closed without any response or reason.

Link to plugin?

Old plugin: https://www.spigotmc.org/resources/quickshop-reremake-1-20-2-ready-multi-currency.62575/

Plugin I switched to: https://www.spigotmc.org/resources/quickshop-hikari-a-powerful-user-friendly-and-relieable-chestshop-plugin-1-18-2-1-21.100125/

I meant for the fabledskyblock?

Sh3r1ffCZ commented 4 months ago

Description

Hello, the reason I marked this as a bug is because "QuickShop-Reremake" had an integration option for the FabledSkyblock plugin. I had to switch to the new shop "QuickShop-Hikari", which unfortunately does not have this. The problem is that players can create shops on foreign islands and then the island owner can't enter them. These "their" shops can also be bought out, so they can actually rob that player as well. Would it be possible to add the integration that this plugin previously had? I wouldn't want to change the whole Skyblock plugin or shop plugin because of this. Thank you very much

Steps to reproduce

Anyone can set up shop on a foreign island

Expected Behaviour

Old Reremake Config:

FabledSkyblock Integration fabledskyblock:

If a player wants to create a shop, the player must have the quickshop-create flag.

If a player wants to trade a shop, the player must have the quickshop-trade flag.

enable: true #Should we prevent the creation of a shop or trade with a shop outside FabledSkyblock's area? whitelist-mode: false create:

  • MEMBER
  • OWNER
  • OPERATOR
  • COOP

Screenshots

image

/quickshop paste URL

https://ghost-chu.github.io/quickshop-hikari-paste-viewer/?remote=https%3A%2F%2Fbytebin.lucko.me%2FHlyKSkH2bd

Additional Context

No response

Checklist

  • [x] I'm running Paper or Spigot, and not a fork
  • [x] I confirm that Paper/Spigot has been updated to the latest build
  • [x] I confirm that QuickShop-Hikari has been updated to the latest stable version released on Modrinth (or the latest CI version)
  • [ ] I confirm that I have not read these checkboxes and therefore I just ticked them all.
  • [x] I confirm that I'm using QuickShop-Hikari, not QuickShop-Reremake, and I'm well aware that they're maintained by different people, and that Reremake issues shouldn't be reported here.
  • [x] I confirm that I am running a server that is not a Hybird Server, (e.g. Mohist, Magma, CatServer, Banner, etc.), and I am aware that QuickShop-Hikari may not function properly on a Forge/Fabric hybrid server, and I am running at my own risk on such a server program, and I am aware that the I run such server-side programs at my own risk and know that I will not receive any support or help for this behavior.
  • [x] I am well aware that if the Issue Ticket is not filled out correctly and completely, it will simply be closed without any response or reason.

Link to plugin?

Old plugin: https://www.spigotmc.org/resources/quickshop-reremake-1-20-2-ready-multi-currency.62575/ Plugin I switched to: https://www.spigotmc.org/resources/quickshop-hikari-a-powerful-user-friendly-and-relieable-chestshop-plugin-1-18-2-1-21.100125/

I meant for the fabledskyblock?

Oh sorry: https://songoda.com/product/fabledskyblock-13

creatorfromhell commented 4 months ago

Description

Hello, the reason I marked this as a bug is because "QuickShop-Reremake" had an integration option for the FabledSkyblock plugin. I had to switch to the new shop "QuickShop-Hikari", which unfortunately does not have this. The problem is that players can create shops on foreign islands and then the island owner can't enter them. These "their" shops can also be bought out, so they can actually rob that player as well. Would it be possible to add the integration that this plugin previously had? I wouldn't want to change the whole Skyblock plugin or shop plugin because of this. Thank you very much

Steps to reproduce

Anyone can set up shop on a foreign island

Expected Behaviour

Old Reremake Config:

FabledSkyblock Integration fabledskyblock:

If a player wants to create a shop, the player must have the quickshop-create flag.

If a player wants to trade a shop, the player must have the quickshop-trade flag.

enable: true #Should we prevent the creation of a shop or trade with a shop outside FabledSkyblock's area? whitelist-mode: false create:

  • MEMBER
  • OWNER
  • OPERATOR
  • COOP

Screenshots

image

/quickshop paste URL

https://ghost-chu.github.io/quickshop-hikari-paste-viewer/?remote=https%3A%2F%2Fbytebin.lucko.me%2FHlyKSkH2bd

Additional Context

No response

Checklist

  • [x] I'm running Paper or Spigot, and not a fork
  • [x] I confirm that Paper/Spigot has been updated to the latest build
  • [x] I confirm that QuickShop-Hikari has been updated to the latest stable version released on Modrinth (or the latest CI version)
  • [ ] I confirm that I have not read these checkboxes and therefore I just ticked them all.
  • [x] I confirm that I'm using QuickShop-Hikari, not QuickShop-Reremake, and I'm well aware that they're maintained by different people, and that Reremake issues shouldn't be reported here.
  • [x] I confirm that I am running a server that is not a Hybird Server, (e.g. Mohist, Magma, CatServer, Banner, etc.), and I am aware that QuickShop-Hikari may not function properly on a Forge/Fabric hybrid server, and I am running at my own risk on such a server program, and I am aware that the I run such server-side programs at my own risk and know that I will not receive any support or help for this behavior.
  • [x] I am well aware that if the Issue Ticket is not filled out correctly and completely, it will simply be closed without any response or reason.

Link to plugin?

Old plugin: https://www.spigotmc.org/resources/quickshop-reremake-1-20-2-ready-multi-currency.62575/ Plugin I switched to: https://www.spigotmc.org/resources/quickshop-hikari-a-powerful-user-friendly-and-relieable-chestshop-plugin-1-18-2-1-21.100125/

I meant for the fabledskyblock?

Oh sorry: https://songoda.com/product/fabledskyblock-13

cheers, so it's the same one that is open source here: https://github.com/craftaro/FabledSkyBlock?tab=readme-ov-file ?

Sh3r1ffCZ commented 4 months ago

Description

Hello, the reason I marked this as a bug is because "QuickShop-Reremake" had an integration option for the FabledSkyblock plugin. I had to switch to the new shop "QuickShop-Hikari", which unfortunately does not have this. The problem is that players can create shops on foreign islands and then the island owner can't enter them. These "their" shops can also be bought out, so they can actually rob that player as well. Would it be possible to add the integration that this plugin previously had? I wouldn't want to change the whole Skyblock plugin or shop plugin because of this. Thank you very much

Steps to reproduce

Anyone can set up shop on a foreign island

Expected Behaviour

Old Reremake Config:

FabledSkyblock Integration fabledskyblock:

If a player wants to create a shop, the player must have the quickshop-create flag.

If a player wants to trade a shop, the player must have the quickshop-trade flag.

enable: true #Should we prevent the creation of a shop or trade with a shop outside FabledSkyblock's area? whitelist-mode: false create:

  • MEMBER
  • OWNER
  • OPERATOR
  • COOP

Screenshots

image

/quickshop paste URL

https://ghost-chu.github.io/quickshop-hikari-paste-viewer/?remote=https%3A%2F%2Fbytebin.lucko.me%2FHlyKSkH2bd

Additional Context

No response

Checklist

  • [x] I'm running Paper or Spigot, and not a fork
  • [x] I confirm that Paper/Spigot has been updated to the latest build
  • [x] I confirm that QuickShop-Hikari has been updated to the latest stable version released on Modrinth (or the latest CI version)
  • [ ] I confirm that I have not read these checkboxes and therefore I just ticked them all.
  • [x] I confirm that I'm using QuickShop-Hikari, not QuickShop-Reremake, and I'm well aware that they're maintained by different people, and that Reremake issues shouldn't be reported here.
  • [x] I confirm that I am running a server that is not a Hybird Server, (e.g. Mohist, Magma, CatServer, Banner, etc.), and I am aware that QuickShop-Hikari may not function properly on a Forge/Fabric hybrid server, and I am running at my own risk on such a server program, and I am aware that the I run such server-side programs at my own risk and know that I will not receive any support or help for this behavior.
  • [x] I am well aware that if the Issue Ticket is not filled out correctly and completely, it will simply be closed without any response or reason.

Link to plugin?

Old plugin: https://www.spigotmc.org/resources/quickshop-reremake-1-20-2-ready-multi-currency.62575/ Plugin I switched to: https://www.spigotmc.org/resources/quickshop-hikari-a-powerful-user-friendly-and-relieable-chestshop-plugin-1-18-2-1-21.100125/

I meant for the fabledskyblock?

Oh sorry: https://songoda.com/product/fabledskyblock-13

cheers, so it's the same one that is open source here: https://github.com/craftaro/FabledSkyBlock?tab=readme-ov-file ?

Yess

creatorfromhell commented 2 months ago

Merged into master issue #1756