search

QuickShop-Community / QuickShop-Hikari

QuickShop is a shop plugin that allows players to easily sell/buy any items from a chest without any commands. In fact, none of the commands that QuickShop provides are ever needed by a player.
https://modrinth.com/plugin/quickshop-hikari
GNU General Public License v3.0
84 stars 52 forks source link

[BUG] Items with metadata are no longer detected as stock #1639

Open quiquelhappy opened 2 months ago

quiquelhappy commented 2 months ago

Description

This affects a variety of items, such as

Steps to reproduce

Expected Behaviour

The items should be taken into account, just like they did on QuickShop-Reremake

Screenshots

imagen imagen

/quickshop paste URL

https://paste.helpch.at/raw/wuyexapagu

Additional Context

this along with the item exploit mentioned in https://github.com/QuickShop-Community/QuickShop-Hikari/issues/1632 are the only issues we personally found when migrating to hikari. It would be great to fix both specially now that people are migrating to the new version due to 1.21

Checklist

creatorfromhell commented 2 months ago

Looking at this, will probably add a new option for checks to this that I've been working on for another plugin

creatorfromhell commented 1 month ago

Description

This affects a variety of items, such as

  • Spawners with metada (in our case our server uses lore to keep spawner type info)
  • Filled shulker boxes
  • ... probably more

Steps to reproduce

  • Create a shop
  • Place items with metadata on the shop

Expected Behaviour

The items should be taken into account, just like they did on QuickShop-Reremake

Screenshots

imagen imagen

/quickshop paste URL

https://paste.helpch.at/raw/wuyexapagu

Additional Context

this along with the item exploit mentioned in #1632 are the only issues we personally found when migrating to hikari. It would be great to fix both specially now that people are migrating to the new version due to 1.21

Checklist

  • [x] I'm running Paper or Spigot, and not a fork
  • [x] I confirm that Paper/Spigot has been updated to the latest build
  • [x] I confirm that QuickShop-Hikari has been updated to the latest stable version released on Modrinth (or the latest CI version)
  • [ ] I confirm that I have not read these checkboxes and therefore I just ticked them all.
  • [x] I confirm that I'm using QuickShop-Hikari, not QuickShop-Reremake, and I'm well aware that they're maintained by different people, and that Reremake issues shouldn't be reported here.
  • [x] I confirm that I am running a server that is not a Hybird Server, (e.g. Mohist, Magma, CatServer, Banner, etc.), and I am aware that QuickShop-Hikari may not function properly on a Forge/Fabric hybrid server, and I am running at my own risk on such a server program, and I am aware that the I run such server-side programs at my own risk and know that I will not receive any support or help for this behavior.
  • [x] I am well aware that if the Issue Ticket is not filled out correctly and completely, it will simply be closed without any response or reason.

Try the jar in this zip: QuickShop-Hikari-6.2.0.6.zip and set work-type to 3.