QuickShop-Community / QuickShop-Hikari

QuickShop is a shop plugin that allows players to easily sell/buy any items from a chest without any commands. In fact, none of the commands that QuickShop provides are ever needed by a player.
https://modrinth.com/plugin/quickshop-hikari
GNU General Public License v3.0
84 stars 52 forks source link

[BUG] Non-OP players bypass the Quickshop lock #1708

Closed zirran closed 1 month ago

zirran commented 1 month ago

Description

I used the plugin for the leaves side, and then a player with non-OP permissions bypassed the QuickShop permission group (I had set "quickshop.other.open" to "false" with LP and the player was in the permission group) and took the items in the store.

Steps to reproduce

  1. Set up permission groups
  2. Turn off the player's "quickshop.other.open" permission
  3. Remove the player's OP permission
  4. The player tries to open the store's chest
  5. The player successfully opens and picks up the item

Expected Behaviour

Block the player and prevent him from opening it

Screenshots

1

2

3

4

ff72cb1231b820056056abb0bef01a3d

https://github.com/user-attachments/assets/17052170-1b4b-4874-9ce1-2eead29056f2

/quickshop paste URL

https://ghost-chu.github.io/quickshop-hikari-paste-viewer/?remote=https%3A%2F%2Fbytebin.lucko.me%2FVlF67CuakR

Additional Context

No response

Checklist

YuanYuanOwO commented 1 month ago

remove all quickshop related permissions from player group.

quickshop.player is all you need.

YuanYuanOwO commented 1 month ago

I've closed the issue for now, the test result may be a conflict with residence, further testing is needed. The solution is to change SNEAKING_RIGHT_CLICK_SIGN in interaction.yml.

I'll open a new issue if there are any new developments