QuickShop-Community / QuickShop-Hikari

QuickShop is a shop plugin that allows players to easily sell/buy any items from a chest without any commands. In fact, none of the commands that QuickShop provides are ever needed by a player.
https://modrinth.com/plugin/quickshop-hikari
GNU General Public License v3.0
84 stars 52 forks source link

SubCommand_Find: Add finding enchantments on books and gear #1716

Closed SarahGreyWolf closed 1 month ago

SarahGreyWolf commented 1 month ago

This feature allows users to use /qs find to search for enchantments on both Enchanted Books and Gear such as Swords, Pickaxes and Armour.

I previously made this for PotatoCraft-Studio/QuickShop-Reremake and have seen it get a lot of use on minecraft servers.

An example of its usage would be a shop selling a Diamond Sword with Sharpness 5, performing /qs find sharpness would direct you towards that shop, it is a very useful tool for servers that have large market areas, where just searching for Enchanted Book is not good enough and the option that allows just the first Enchantment is equally not good enough for multi-enchant books, as well as when you wish to find upgraded gear being sold at said market places.

SarahGreyWolf commented 1 month ago

I tend to forget about final, bad habit, would be helpful to have a style guide

creatorfromhell commented 1 month ago

I tend to forget about final, bad habit, would be helpful to have a style guide

indeed, I have to get everything in the core styled according to the style guide I have in Intellij, then I'll have to add the github bot for it.