QuickShop-Community / QuickShop-Hikari

QuickShop is a shop plugin that allows players to easily sell/buy any items from a chest without any commands. In fact, none of the commands that QuickShop provides are ever needed by a player.
https://modrinth.com/plugin/quickshop-hikari
Other
91 stars 56 forks source link

[BUG] qs history cannot be use in folia #1787

Closed cgw2023 closed 1 month ago

cgw2023 commented 1 month ago

Description

using version c9d4d6c6b0ebfcad808ecc8ab4cd5bebbcd4a5e8 when /qs history is used, error occurs, menu cannot be displayed.

Steps to reproduce

  1. use /qs history

/qs history can be used if the server is launched in paper/purpur, but not folia with the same qs files

Expected Behaviour

menu can be shown

Screenshots

No response

/quickshop paste URL

https://ghost-chu.github.io/quickshop-hikari-paste-viewer/?remote=https%3A%2F%2Fbytebin.lucko.me%2FdVgggWjzeX

Additional Context

No response

Checklist

creatorfromhell commented 1 month ago

Post the full error please

cgw2023 commented 1 month ago

Post the full error please here it is https://mclo.gs/zq4tr2N

creatorfromhell commented 1 month ago

Post the full error please here it is https://mclo.gs/zq4tr2N

QuickShop-Hikari-6.2.0.7.zip

cgw2023 commented 1 month ago

Post the full error please here it is https://mclo.gs/zq4tr2N

QuickShop-Hikari-6.2.0.7.zip

great, it is working, thank you so much

cgw2023 commented 1 month ago

Post the full error please here it is https://mclo.gs/zq4tr2N

QuickShop-Hikari-6.2.0.7.zip

good news, it works. but bad news, it broke addon API seems like [00:37:07 ERROR]: [qsaddon-discordsrv] Failed to register events for class com.ghostchu.quickshop.addon.discordsrv.listener.QuickShopEventListener because com/ghostchu/quickshop/api/event/ShopOwnershipTransferEvent does not exist. [00:37:01 ERROR]: [QuickShopForm] Failed to register events for class ltd.rymc.form.quickshop.handler.ShopHandlerHikari because com/ghostchu/quickshop/api/event/ShopClickEvent does not exist.

creatorfromhell commented 1 month ago

Post the full error please here it is https://mclo.gs/zq4tr2N

QuickShop-Hikari-6.2.0.7.zip

good news, it works. but bad news, it broke addon API seems like [00:37:07 ERROR]: [qsaddon-discordsrv] Failed to register events for class com.ghostchu.quickshop.addon.discordsrv.listener.QuickShopEventListener because com/ghostchu/quickshop/api/event/ShopOwnershipTransferEvent does not exist. [00:37:01 ERROR]: [QuickShopForm] Failed to register events for class ltd.rymc.form.quickshop.handler.ShopHandlerHikari because com/ghostchu/quickshop/api/event/ShopClickEvent does not exist.

Nah this was broke on other commits, the local add-on builds are already are fixed

cgw2023 commented 1 month ago

Post the full error please here it is https://mclo.gs/zq4tr2N

QuickShop-Hikari-6.2.0.7.zip

good news, it works. but bad news, it broke addon API seems like [00:37:07 ERROR]: [qsaddon-discordsrv] Failed to register events for class com.ghostchu.quickshop.addon.discordsrv.listener.QuickShopEventListener because com/ghostchu/quickshop/api/event/ShopOwnershipTransferEvent does not exist. [00:37:01 ERROR]: [QuickShopForm] Failed to register events for class ltd.rymc.form.quickshop.handler.ShopHandlerHikari because com/ghostchu/quickshop/api/event/ShopClickEvent does not exist.

Nah this was broke on other commits, the local add-on builds are already are fixed

I don't have such problem when I build the jar with c9d4d6c6b0ebfcad808ecc8ab4cd5bebbcd4a5e8 , may I ask, how do I get a jar that can have these addon listener and qs history work together? which/any version or branch i can build by myself?

creatorfromhell commented 1 month ago

Post the full error please here it is https://mclo.gs/zq4tr2N

QuickShop-Hikari-6.2.0.7.zip

good news, it works. but bad news, it broke addon API seems like [00:37:07 ERROR]: [qsaddon-discordsrv] Failed to register events for class com.ghostchu.quickshop.addon.discordsrv.listener.QuickShopEventListener because com/ghostchu/quickshop/api/event/ShopOwnershipTransferEvent does not exist. [00:37:01 ERROR]: [QuickShopForm] Failed to register events for class ltd.rymc.form.quickshop.handler.ShopHandlerHikari because com/ghostchu/quickshop/api/event/ShopClickEvent does not exist.

Nah this was broke on other commits, the local add-on builds are already are fixed

I don't have such problem when I build the jar with c9d4d6c , may I ask, how do I get a jar that can have these addon listener and qs history work together? which/any version or branch i can build by myself?

it's in my PR #1781 . I'll be posting the updated addon jars in the discord momentarily.

creatorfromhell commented 1 month ago

Builds have been released on discord.