Quicksaver / FindBar-Tweak

A firefox add-on that lets you customize the Find Toolbar the way you like it.
https://addons.mozilla.org/firefox/addon/findbar-tweak/
Mozilla Public License 2.0
91 stars 21 forks source link

[req] Customisable quckfind hotkeys + Find As You Type question. #91

Open mzso opened 10 years ago

mzso commented 10 years ago

Hello! This would be pretty useful to anyone not using an english keyboard. The defaults for firefox are / and '. But on my keyboard for the first I either need to use the numeric keyboard or ctrl+6, for the second I need to use ctrl+1.

It's probably of little to no interest, but: Recently I moved to Pale Moon, because I got fed up with the main FF (recently they messed the findbar up) But it has the "Find As You Type", which I use all the time. Would it be hard to implement/enable this functionality with an addon like this?

Quicksaver commented 10 years ago

Enable the preference "search for text when I start typing", this also exists in firefox even without FBT, but it's disabled by default. The only difference I guess pale Moon has is that it enables that by default.

mzso commented 10 years ago

The preference is removed and "accessibility.typeaheadfind" has no effect... It was totally disabled in the latest update. Because of some incompatiblity with HTML5 input fields. (Which is actually an unfixed firefox bug)

What about the requests? Could you add the ability to customise the hotkeys for the two kinds of quick find?

Quicksaver commented 10 years ago

I'm trying to avoid adding the ability to change the shortcuts, because that will very likely clash with other functions/add-ons. Also, it's not as easy to do as it sounds, so I don't know if I will do this.

Also, I can use typeaheadfind in all versions of firefox. If Pale Moon has it disabled, it's its developers fault, and you should ask them to bring it back (to disable this completely instead of actually fixing it is idiotic to be perfectly honest, and I can't find the firefox bug you or its developer refer to, do you have a link?). I can see about re-enabling it though through the add-on.

mzso commented 10 years ago
I'm trying to avoid adding the ability to change the shortcuts, because that will very likely clash with other functions/add-ons. Also, it's not as easy to do as it sounds, so I don't know if I will do this.

Well that's the users responsibility as always, until you have a reset to default feature I don't see it as a problem. What I find interesting (not in a good way) that extensions like keyconfig apparently lack the ability to change these shortcuts, even though they support changing such basic ones as escape and backspace from their defaults.

As for typeahead. This is what the PM dev linked: https://bugzilla.mozilla.org/show_bug.cgi?id=791653 He also mentioned he doesn't know enough about the piece of code involved to fix it.

Quicksaver commented 10 years ago

That's because most of these "simpler" shortcuts aren't actually keyboard shortcuts (which is what keyconfig uses and modifies) but are just specific key handlers that are buried in amidst other handlers. These usually can't be just disabled/modified without affecting other functions inside the handler.

Also, from what that bug mentions, it is only affected in a specific (and still experimental!) types of fields. For the PM dev to decide to disable a whole feature for specific cases like those I still believe was not a good decision. And I also don't know exactly how find ahead is triggered or if I can make sure it is enabled always, that's why I said I don't know if I will do this.

mzso commented 10 years ago
That's because most of these "simpler" shortcuts aren't actually keyboard shortcuts (which is what keyconfig uses and modifies) but are just specific key handlers that are buried in amidst other handlers. These usually can't be just disabled/modified without affecting other functions inside the handler.

I can't say that I actually understand, I guess it makes it too difficult? Too bad.

Also, from what that bug mentions, it is only affected in a specific (and still experimental!) types of fields. For the PM dev to decide to disable a whole feature for specific cases like those I still believe was not a good decision. And I also don't know exactly how find ahead is triggered or if I can make sure it is enabled always, that's why I said I don't know if I will do this.

Well, it's labelled experimental with firefox but the PM dev wants more HTML5 compliance and typeahead breaks it. I knew it was a longshot, I'd just thought it wouldn't hurt to ask.

mzso commented 10 years ago

I was thinking. Isn't it simpler to add an alternative shortcuts to activate the two quick search modes? I see no particular need in overriding the default ones.

Quicksaver commented 10 years ago

Just wanted to let you know that I will try to add some kind of means to add/change shortcuts to activate these two modes (I must have forgotten to reply when you wrote your last comment). It just might take a little while.