search

Quicksaver / OmniSidebar

A firefox add-on designed to provide more control over the behavior of the sidebar.
https://addons.mozilla.org/firefox/addon/omnisidebar/
Mozilla Public License 2.0
33 stars 10 forks source link

add-ons sidebar display #71

Open atomGit opened 9 years ago

atomGit commented 9 years ago

hi Quicksaver!

personally, i much prefer the more minimal, optimized layout for extensions as in AIOS where only the title is shown until a list item is clicked

also, it seems the list is rebuilt every time the sidebar add-on panel is opened which makes it a little slow to display

lastly, the font size is too small

Quicksaver commented 9 years ago

I will see about making some adjustments to the add-ons manager panel.

Also, you can enable the preference "Keep the panel loaded when the sidebar closes" in OSB's options, so it will not have to reload the add-ons manager every time you close the sidebar (but it will need to if you open any other sidebar inbetween).

Keith94 commented 9 years ago

These userstyles work pretty well for that, maybe they can be of some use.

https://userstyles.org/styles/48731/add-ons-manager-in-the-sidebar https://userstyles.org/styles/48732/add-ons-manager-in-the-sidebar-companion

atomGit commented 9 years ago

thanks guys @Quicksaver - if you're going to re-style the list, i'll wait for that instead of using extra styles, but thanks anyway Kieth!

Quicksaver commented 9 years ago

I should mention I don't know exactly what I will do yet. I agree that the add-ons manager sidebar can be improved, but that doesn't mean I will add those exact suggestions or apply those precise userstyles. ;)

atomGit commented 9 years ago

please consider just not re-styling the font size for the add-ons panel - that tiny font is not easily readable at all in my case :) thanks

Quicksaver commented 9 years ago

Could you give the latest beta version 1.5.1b2 a try? (at the top of https://addons.mozilla.org/firefox/addon/omnisidebar/versions/) I've made many changes to the add-ons sidebar, to make it easier to read and use; those userstyles did come in handy, thanks for those. :)

There is however one of your suggestions I don't particularly like, to always hide the buttons until the add-on is clicked. For instance, I use the addons sidebar all the time and I need those buttons constantly in many different add-ons. That behavior makes me need to click each add-on twice, one to show the buttons and another to "do whatever". Which is why I kept the buttons always visible at first.

However I can see how it looks better with the buttons hidden, so I decided to toy with an idea: show the buttons on moving the mouse over the add-on as well, so in most cases you still only need to click the add-on entry once even though the buttons are initially hidden.

I don't want to hide the buttons by default (without the mouseover) because I see it as a hassle like I mentioned. I could hide them (without the mouseover) via an option in the preferences, but that won't happen until I add the per-panel preferences (specific to each different sidebar, such as bookmarks, history, addons, etc). And to hide the addon entries by default without a preference to disable it, I think I would only do it like this (with the mouseover). I don't know what to decide here, so let me know what you guys think about this behavior, I'd really like your opinions. :)

atomGit commented 9 years ago

THANK YOU! i can read the text now :)

it looks like you made the ext. title font bold - no need for that in my opinion - just the standard FF text is fine

the mouseover solution is great

Quicksaver commented 9 years ago

It was actually always bold (I never changed that), it was just too small for you to notice before I guess. :)

Quicksaver commented 9 years ago

Not yet, it's not finished I may still make some changes here and there. ;)

atomGit commented 9 years ago

sorry :) one thing you could add is an add-on count - a/b - where a=total add-ons and b=enabled add-ons

Quicksaver commented 9 years ago

That'll come with the per-panels preferences. :)

Keith94 commented 9 years ago

Nice work on the new styling.

There's a bug with the menu popups. They appear misaligned on the far right side, and it's impossible to click and drag the scrollbars. For example, install Enhanced Steam, go to its options and use the region menus near the bottom.

I do kinda like the categories popup from banthaz's style. You can test it if you use this method: Via a bookmark, with the address “about:addons”, set to open in the sidebar. You could possibly add it as an optional thing later on.

Also for the add-on counter idea, there's a userstyle made for that here if it'll come in handy.

Quicksaver commented 9 years ago

There's a bug with the menu popups. They appear misaligned on the far right side, and it's impossible to click and drag the scrollbars.

Right you are! Just uploaded beta version 1.5.1b6 with a fix for that, here's to hoping I didn't break anything else in the process.

I do kinda like the categories popup from banthaz's style.

It is interesting indeed. Added it to my list of "thing to check out for the per-panels preferences", thanks for the suggestion!

tophf commented 9 years ago

Regardless of my love for OSB, I had to revert this commit (1eb58c4) for addons.css entirely, after unsuccessfully trying to tolerate the change for two days and then failing to override it with Stylish or userchrome.css due to lots of !important in the css (are those really needed?).

Quicksaver commented 9 years ago

@tophf, after a few days of using it myself more extensively, I have to agree. Some transitions would probably help, but overall I think this should go behind a preference as well.

I will push a quick update with all the fixes in the previous commit, except for the hover effects disabled. By the way, probably not all the !important are needed, but many really are, and it's just tedious, not to mention time consuming, to go through them all to see if they are or if I can find a greater degree of specificity to still apply the rules without them. But if you do run into any trouble with styling something and you think a few specific rule changes about this would help then let me know and I will definitely check it out!

@atomGit, I won't be adding this preference directly in the add-on just yet, because I still haven't worked out how to apply the panel-specific preferences (like this one). But I don't want you to live without it, since you were the one who suggested it in the first place. So you can get the hover effects back by applying the following stylesheet through stylish. I hope that will be enough, for now at least.

.inSidebar .addon:not([selected]):not(:hover) .disabled-postfix,
.inSidebar .addon:not([selected]):not(:hover) .update-postfix {
    display: none !important;
}

.inSidebar .addon:not([selected]):not(:hover) :-moz-any(.description-outer-container,.control-container,.addon-control.update,.include-update,.update-available),
.inSidebar .addon:not([selected]):not(:hover) .status-container > hbox {
    visibility: collapse !important;
}

.inSidebar .addon:not([selected]):not(:hover) .advancedinfo-container {
    margin-top: -20px !important;
}

.inSidebar .addon:-moz-any([selected],:hover) .icon-container,
.inSidebar .addon:-moz-any([selected],:hover) .icon {
    width: 32px !important;
    height: 32px !important;
}

.inSidebar .addon:not([selected]):not(:hover) .icon-container,
.inSidebar .addon:not([selected]):not(:hover) .icon {
    width: 16px !important;
    height: 16px !important;
}

.inSidebar .addon .content-container { 
    margin: 3px 0 !important;
}

.inSidebar .addon:not([selected]):not(:hover) .icon-container {
    margin-top: 2px !important;
}

.inSidebar .addon:-moz-any([selected],:hover) .icon-container {
    margin-top: 7px !important;
}
atomGit commented 9 years ago

no worries - i have to admit that after using it awhile, i actually find the css animations a bit annoying - i would suggest either leaving it the way it was, or adding an option to collapse and display the whole row only on click like AiOS

i am most appreciative of the larger text though :)

Quicksaver commented 9 years ago

What you said made me think, it really shouldn't need all those !important... I figured out how to load the stylesheet later in the CSS cascade, and I've already removed almost all of the !important from the add-ons manager stylesheet. Many other stylesheets still have them but I'll remove them on an as-needed or nothing-else-to-do basis.

jasonbfraser commented 9 years ago

Hi! Just noticed the reversion of the addons stylesheet in the latest update on AMO (1.5.1->1.5.2). I personally liked the hover feature, and look forward to it's return.

I do have another suggestion for the page though. I tweaked the addon page's stylesheet by shrinking the category icons from 32px to 24px, which made things a little more compact, and also made all the icons visible when the sidebar is at narrower widths. I was wondering if that would be a change you might be interested in.

I added the following to a Stylish codepage:

  .inSidebar .category {
    padding: 3px !important;
    height: 30px !important;
  }
  .inSidebar .category image {
    width: 24px !important;
    height: 24px !important;
  }
Quicksaver commented 9 years ago

I never even remembered to tweak the category icons, thanks for the suggestion, I'll keep it in mind for the future!

Also, you can get the hover effects back easily with stylish, just read https://github.com/Quicksaver/OmniSidebar/issues/71#issuecomment-73691159 a couple of posts above. :)

my42centsw0rth commented 9 years ago

I am so freakin' sad the mouse over is gone and i don't have a darn clue what 'stylish' is to get it back. Will you please fix a way I can understand to get it back? This and Forecastfox are the best and first addons I make sure I have. And with the last update, my OCD was soooo happy!!

Thanks for making such an awesome addon! :)

Quicksaver commented 9 years ago

@my42centsw0rth, Stylish ;) Just install the add-on and copy the code I wrote in https://github.com/Quicksaver/OmniSidebar/issues/71#issuecomment-73691159 in a new style in it and save it and you will have your hover effects back for now.

my42centsw0rth commented 9 years ago

I LOVE YOU, Luis Miguel! Took me all of 5 seconds to do...LITERALLY!! You do an overwhelmingly amazing job.

Thank You!! Lucy Wain

On Tue, Feb 10, 2015 at 5:08 PM, Luís Miguel notifications@github.com wrote:

@my42centsw0rth https://github.com/my42centsw0rth, Stylish https://addons.mozilla.org/firefox/addon/stylish/ ;) Just install the add-on and copy the code I wrote in #71 (comment) https://github.com/Quicksaver/OmniSidebar/issues/71#issuecomment-73691159 in a new style in it and save it and you will have your hover effects back for now.

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/OmniSidebar/issues/71#issuecomment-73804174 .

sergwish commented 9 years ago

Hi, Quicksaver! I also liked a mouseover feature in add-ons panel. With so radically different opinions this feature is a good candidate for a configuration option.

Also, I still don't get the reason to use text on the buttons instead of small icons with text as tooltip. That would take many times less space and look neater.

I like the idea by jasonbfraser of making category icons smaller. In fact, I'd like to have them the same size as all other toolbar icons. User sets the toolbar icons to comfortable size, so they should be comfortable with the size of categories icons as well.

Quicksaver commented 9 years ago

@my42centsw0rth, you're very welcome, love you too. :)

@sergwish:

With so radically different opinions this feature is a good candidate for a configuration option.

Indeed! And I will add this option and probably more eventually. :)

Also, I still don't get the reason to use text on the buttons instead of small icons with text as tooltip.

I thought the same thing, the problem is there are no built-in icons for these buttons, so I'd have to create them as well. I probably will do this in the future as well, just need to find the time for it. I'll re-open the issue so I don't forget about any of these suggestions.

sergwish commented 9 years ago

Also, I still don't get the reason to use text on the buttons instead of small icons with text as tooltip.

I thought the same thing, the problem is there are no built-in icons for these buttons, so I'd have to create them as well. I probably will do this in the future as well, just need to find the time for it. I'll re-open the issue so I don't forget about any of these suggestions.

Just a stray thought: can you use the firefox program icons for that? If so, there are fitting icons:

Keith94 commented 9 years ago

@Quicksaver Bug 989469 has landed in Nightly, so your CSS will need an update eventually.