Quicksaver / Puzzle-Toolbars

A Firefox that adds many toolbar choices to fully customize the browser window.
https://addons.mozilla.org/firefox/addon/puzzle-toolbars/
Mozilla Public License 2.0
19 stars 4 forks source link

Removing widgets doesn't resize add-on bar #19

Closed Keith94 closed 10 years ago

Keith94 commented 10 years ago

Steps to reproduce:

  1. Position add-on bar in location bar.
  2. Add a few widgets to add-on bar.
  3. Right click the rightmost widget and click Remove from Toolbar command.

Actual results:

Add-on bar stays the same width and shows a blank space where the removed widget was.

Expected results:

The add-on bar should resize down to be smaller.

Quicksaver commented 10 years ago

Hi Keith, thank you very much for all your bug reporting! I've already uploaded version 1.2.7 (https://addons.mozilla.org/en-US/firefox/addon/the-puzzle-piece/versions/) which should fix this and the other issues you posted.

Keith94 commented 10 years ago

Hi Luís, it's my pleasure.

A small nitpick on this issue, if you set the bar to auto-hide and try my above steps, the widgets are hidden too quickly (instantly). This is with 1.2.7.

Quicksaver commented 10 years ago

Are you sure it still hides instantly? I just tried it (in Windows 8 as well) and the add-on bar is visible after I exit customize. It really is only supposed to show for a second by the way.

Quicksaver commented 10 years ago

I tried increasing the duration the add-on bar stays visible after exiting customize, it was a little short anyway. Could you see if that helps?

Keith94 commented 10 years ago

When I use Remove from Add-on Bar on widget in location bar (when auto-hidden) is when the bar hides instantly, which is different from when it's placed in the corner for instance. Sorry if I was unclear.

And the bar also looks fine after exiting customize.

Keith94 commented 10 years ago

Ah, I should mention after step 2 in OP you must exit customize mode, then remove widget.

Quicksaver commented 10 years ago

Yes I understood what you meant. ;) I did forget about that case, that last patch should fix that.

Keith94 commented 10 years ago

Great! It works nicely now.