Quicksaver / Puzzle-Toolbars

A Firefox that adds many toolbar choices to fully customize the browser window.
https://addons.mozilla.org/firefox/addon/puzzle-toolbars/
Mozilla Public License 2.0
19 stars 4 forks source link

When in locaiton bar, puzzle piece should hide too #29

Closed Noitidart closed 10 years ago

Noitidart commented 10 years ago

To match behavior when location is "bottom of webpage". The puzzle piece is also hidden when auto-hidden.

Quicksaver commented 10 years ago

This won't work without #28, because you'd have nothing to mouse over to show it again (same reason why if you disable the option to show the puzzle piece icon in the location bar, the autohide feature will be disabled).

yajd commented 10 years ago

Just like when hover over insivible area, for when status bar or bottom of webpage locations, insert like an invisible element, like a stack element that you can stack on top of things. What do you think?

Quicksaver commented 10 years ago

If the urlbar isn't full, then that invisible element would literally be "empty space" for the user, so in this case might as well let it be the PP icon since it doesn't take space away from anything else.

If the urlbar is full, then we run into the same problem that I just mentioned in my last comment in #28.

yajd commented 10 years ago

That's true, invisible space is just a css on the icon to be invis till hover. Very true. Reason I suggested is cuz I like your animations so any reason to see it is nice. haha

yajd commented 10 years ago

I was thinking more about it, if you make the icon piece hide too while its in urlbar (and of course autohide is enabled), but make it a stack element, then i can see 4-5+ more characters of the urlbar. On hover of that corner area then if it shows the puzzle piece then it covers it up, as its stack so it works out in the doc flow. Just thoughts.

Quicksaver commented 10 years ago

That still brings the same issue, that corner area becomes ambiguous, where you'd want to click it to edit the location bar but end up triggering the add-on bar instead because there's no visual cues to it (if you mean to still show the PP icon behind the text in the urlbar, then that I can't do, as it obscures the text and, once again, messes with the "informative" function of the urlbar, personally I'm against it and I don't think the reviewers from AMO would be too fond of it either).

yajd commented 10 years ago

I meant on hover of the corner of urlbar, it should display the PP and of course not come over it, but as it displays it will but the new cut off mark of the text. But when its hidden then the text should flow through it, as its stack element it would be doable.

That still brings the same issue, that corner area becomes ambiguous, where you'd want to click it to edit the location bar but end up triggering the add-on bar instead because there's no visual cues to it

This is also true though if the location is "bottom corner of webpage" and autohide is enabled. What if the webpage loaded had a link in that area. If I wanted to click on that link I would get the puzzle piece. Yes its rare, I would say more rare then a user clicking in the 20px right corner of the urlbar, but both situations rare. So I think same situation, so to be consistent I thought of this.

Quicksaver commented 10 years ago

I meant on hover of the corner of urlbar, it should display the PP and of course not come over it, but as it displays it will but the new cut off mark of the text. But when its hidden then the text should flow through it, as its stack element it would be doable.

That's a thought yes! But it has another problem, the area where the PP is placed doesn't have a clear limitation. It will never be in the actual corner of the urlbar, because that's where the dropmarker for the autocomplete popup and the stop-go-reload button reside. Plus there are other add-ons that add icons to the urlbar (Omnibar for instance), so placing the PP icon correctly for this would have an increased difficulty.

Still, that at least deserves some investigation. Reopening the issue so I don't forget. (No promises yet though!)

This is also true though if the location is "bottom corner of webpage" and autohide is enabled. What if the webpage loaded had a link in that area.

You're right of course. The only difference is the way users usually interact with web content, it's rare the occasions where the user has to interact with the corners, most times they keep the area they are interested in towards the center of the screen by constantly scrolling the page (main exception to this "rule" would be facebook). But that doesn't take away from your point, it's a valid point of course, one I'm perfectly aware of.

Quicksaver commented 10 years ago

Wait, I'm not sure we're thinking this one through (or I'm still not understanding you). This would work fine for hiding the PP icon alone (when the add-on bar is closed), but if it's opened then what's the difference between this and just defining a percentage of the urlbar area to hover to show the add-on bar? By moving the mouse to the corner, it'd immediately show the whole add-on bar, not just the PP icon, as that would involve more "wait" as an action.

yajd commented 10 years ago

Cool man! I had to run for some work I got some more and will be back soon I love disscussment cool ideas come of it lol

Quicksaver commented 10 years ago

Closing this again as I don't see how this would work effectively (as per my last comment).