search

Quicksaver / Puzzle-Toolbars

A Firefox that adds many toolbar choices to fully customize the browser window.
https://addons.mozilla.org/firefox/addon/puzzle-toolbars/
Mozilla Public License 2.0
19 stars 4 forks source link

Req: highlight icons on mouse over #42

Closed seascape closed 9 years ago

seascape commented 10 years ago

My current fallback browser, Pale Moon 24, is running A Better Firefox Add-on Bar, and I like that it automatically and instantly "indents" any add-on icon I move my mouse over. For example, in this screenshot I am hovering over Ghostery; note its embossing:

untitled

It would be nice to see something similar as an option in The Puzzle Piece; it makes the UI feel more reactive. (A few add-ons' icons do this automatically (CookieSafe is one), and those effects do work with The Puzzle Piece. But I would like all icons to do this without them needing to code for it themselves.)

Quicksaver commented 10 years ago

Hovering the icons (any icon) in the add-on bar should give you a greyish background, similar to the one in your screenshot. Is this not happening for you? Beyond that I don't believe I will add this, it's an incredibly specific option that would only add complexity to the code with very little reward. I also think this would be a better fit for a theme rather than an add-on. I'm sorry to disappoint on this one.

seascape commented 10 years ago

I see. Perhaps I can't see your gray highlight because The Puzzle Piece is skinned by my persona? (It looks like a starry night sky.) It might be nice to be able to disable The Puzzle Piece using the persona in cases like this where it seems to interfere with intended functionality. I'd be happy to have a plain-colored add-on bar like in the Pale Moon 24 screenshot above.

By the way, I do see the gray highlights when I put The Puzzle Piece in the URL bar, but that is not my preferred usage.

Quicksaver commented 10 years ago

Hmm, perhaps you stumbled upon another issue that I hadn't considered. I think the real issue here is that the hover effects are hardcoded as dark like that, but in dark personas they won't be seen. I'll see about finding a way to make them contrast in these cases.

seascape commented 10 years ago

Ah. I just took a veeeeery close look at The Puzzle Piece, face right up to my LCD, and I can't see any animation or highlight on mouseover. :) Here is what it looks like when hovering over Ghostery with my night sky persona (which seems appropriate for Nightly):

untitled-1

Quicksaver commented 10 years ago

There should be something there at least, even if barely visible. Could you try disabling the persona just to make sure it appears without it?

seascape commented 10 years ago

Sure. It works (mostly, small bug) with no persona:

untitled-1

The bug is that the highlight disappears when my mouse is over the middle of the Ghostery icon, as it is here:

untitled-2

Only Ghostery's outer edges trigger the highlight. Perhaps the number rendered on top of the icon is interfering somehow? (I also noticed this when I briefly had The Puzzle Piece up in the location bar.)

Quicksaver commented 10 years ago

That's weird, I'll check out the issue with Ghostery as well. Also, could you get me the link to that persona if possible? I'd like to see if it's the persona itself that's causing the hover effects to not appear.

seascape commented 10 years ago

Sure, it's a modified version of an older version of Nightly by Ken Saunders: https://addons.mozilla.org/en-US/firefox/addon/nightly/

The current version's planet looks somewhat different. Guess the exact version I use is no longer available.

I use the vertical tabs feature of Tab Utilities so I often have to make personas vertically taller so that they cover the up-to-1080 vertical height of my tab bar. Otherwise my tab bar background would be mostly white (ugh) or whatever other random color the persona specified.

Quicksaver commented 10 years ago

I can see the hover effect (barely) with that persona. Are you 100% sure you can't see it? If you can't then that's another issue. (It really is nearly impossible to see it but it's there, I can only see the left and right border, not the actual background effect)

seascape commented 10 years ago

You're right, it is there. I have to stare very intently at the few stars (bright areas) in the relevant border zones to see it.

Having an unskinned add-on bar option (like in first screen above) would be good, I think.

Quicksaver commented 10 years ago

That will happen eventually, as I believe personas will stop carrying a bottom image in the future. But in the meantime there's no harm in skinning the add-on bar, as long as I get the hover effects to contrast correctly at least. In case I can't, I will consider that as an alternative of course.

seascape commented 10 years ago

Ah, gotcha.

I just installed The Puzzle Piece in Pale Moon 24 to see how it'd work. Here's how it looks, FYI: untitled-1

The persona is modified Aurora Australis: https://addons.mozilla.org/en-US/firefox/addon/aurora-australis/

Once again the highlights are effectively invisible. From L to R the icons are Download Statusbar, SwiffOut (squished?), Stylish, Scriptish, KeeFox #1 (squished), KeeFox #2 (squished), Default User Agent, RefControl, Ghostery, Adblock Edge, Permit Cookie, Add-on Compatibility Reporter. The Adblock Edge delay still happens. Must be another add-on, not Nightly.

Just for your information!

Hmm, it doesn't seem to ever hide in Pale Moon 24. I suppose you don't need to support that far back, though. I'll be upgrading to a more recent browser as soon as I get my UI looking good in them. Almost there...

Quicksaver commented 10 years ago

Not autohiding is definitely a bug, but I will be dropping compatibility with Firefox 29 and below with the next update (for other reasons), so if it ever does that when you change please let me know.

Quicksaver commented 9 years ago

I've made it so hovering the ghostery counter shows the effect behind the button like it should. I also added better contrast to these effects when using a dark theme. This is all also in beta version 2b4 :)