Quicksaver / Puzzle-Toolbars

A Firefox that adds many toolbar choices to fully customize the browser window.
https://addons.mozilla.org/firefox/addon/puzzle-toolbars/
Mozilla Public License 2.0
19 stars 4 forks source link

[Request] always hide add-on bar in Fullscreen mode #46

Closed VolMi closed 10 years ago

VolMi commented 10 years ago

I have disabled "Hide the add-on bar automatically" but I think in fullscreen mode (F11), it should always disappear like all other UI elements do.

Quicksaver commented 10 years ago

(I assume you mean when the add-on bar is in the corner)

I'm torn about this. On the one hand, to achieve that behavior is extremely simple, just enable that preference. On the other hand, I can see why it's not consistent that all the toolbars hide in fullscreen but the add-on bar doesn't.

I'll see what I can do about this for the next version.

VolMi commented 10 years ago

(I assume you mean when the add-on bar is in the corner)

Exactly.

It's no severe issue of course (you actually solved all those). I just think if "fullscreen mode" is defined as "content only" it is a very valid exception from the general rule defined in TPP.

Note, there is a setting browser.fullscreen.autohide which describes the behaviour of FF's default bars in fullscreen.

Quicksaver commented 10 years ago

I've just uploaded beta version 2b5 (https://addons.mozilla.org/firefox/addon/the-puzzle-piece/versions/, it will install as "Puzzle Toolbars" as I'm planning a name change) which should correctly hide the toolbars when that option is enabled. If you could give it a try and let me know what you think of its behavior I would appreciate it.

VolMi commented 10 years ago

This is very well thought! It hides nicely in fullscreen and shows up again upon hovering, like FF's own toolbars do. You also respect the browser.fullscreen.autohide setting. Very nice, thank you once again!

Quicksaver commented 10 years ago

You're very welcome, I'm glad everything's working as it should now. :)