Quicksaver / Puzzle-Toolbars

A Firefox that adds many toolbar choices to fully customize the browser window.
https://addons.mozilla.org/firefox/addon/puzzle-toolbars/
Mozilla Public License 2.0
19 stars 4 forks source link

Losing all add-on icons in Puzzle Toolbars on reboot #58

Closed paulderdash closed 9 years ago

paulderdash commented 9 years ago

Using 2b9. May be my particular configuration, but occasionally I am losing all my icons in the (bottom right corner) toolbar on rebooting. I have to repopulate using Customize. I haven't been able to detect a pattern here e.g. not closing browser before rebooting, so I am not able to point you to where the problem potentially lies! Could be another add-on that is causing this. Doesn't happen all the time, only sometimes.

Quicksaver commented 9 years ago

Could you try the final version 2 (you can find it at the top of https://addons.mozilla.org/firefox/addon/puzzle-toolbars/versions/) for a few days and see if it also happens there please?

paulderdash commented 9 years ago

Version 2 now installed. Will let you know if it happens again. Thanks Luiz for a great add-on.

paulderdash commented 9 years ago

Unfortunately it still happens with version 2 ...

On 7 November 2014 13:20, Luís Miguel notifications@github.com wrote:

Could you try the final version 2 (you can find it at the top of https://addons.mozilla.org/firefox/addon/puzzle-toolbars/versions/) for a few days and see if it also happens there please?

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/Puzzle-Toolbars/issues/58#issuecomment-62129572 .

Quicksaver commented 9 years ago

This doesn't happen to me at all in any of my profiles unfortunately, but I do believe you of course, as it does happen to me in another add-on of mine which uses a similar (but outdated) code.

Would you be ok with doing some debugging for me, please? I'll post the details later as there's something I want to look into before.

paulderdash commented 9 years ago

Sure! As I said, it only happens occasionally - I can't predict when :-)

On 10 November 2014 20:02, Luís Miguel notifications@github.com wrote:

This doesn't happen to me at all in any of my profiles unfortunately, but I do believe you of course, as it does happen to me in another add-on of mine which uses a similar (but outdated) code.

Would you be ok with doing some debugging for me, please? I'll post the details later as there's something I want to look into before.

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/Puzzle-Toolbars/issues/58#issuecomment-62425999 .

Quicksaver commented 9 years ago

Ok, so this may take a little bit of an effort, so I apologize in advance, but this doesn't happen to me at all, I've had Puzzle Toolbars installed pretty much since day one and it's never lost any icon.

Here's what you need to do right now:

The next time this happens, do this immediately after the browser starts; try to memorize the shortcut if you don't know it already, so you don't need to come here, the less webpages you load before copying the console's contents the better (none is best):

After you've gotten the console's contents you can disable/remove the "CustomizableUI Debugger" add-on and restore your homepage.

Hopefully the console's log will be enough so that I can figure this out.

Quicksaver commented 9 years ago

BTW, I forgot to mention, if you use my other add-on The Fox, Only Better let me know, as its current version is probably not compatible with that beta of Puzzle Toolbars I linked you to, and I'll need to upload a new version for it.

paulderdash commented 9 years ago

Hi Luis

Please check you gave me the correct link for the CustomizableUI Debugger? I see 2 zip files to do with temperature?

Rgds - Paul

On 16 November 2014 21:43, Luís Miguel notifications@github.com wrote:

Ok, so this may take a little bit of an effort, so I apologize in advance, but this doesn't happen to me at all, I've had Puzzle Toolbars installed pretty much since day one and it's never lost any icon.

Here's what you need to do right now:

  • Install the latest beta version 2.0.1b1 of Puzzle Toolbars at https://addons.mozilla.org/firefox/addon/puzzle-toolbars/versions/, this is only to make sure you have the latest code, closest to mine
  • Install this little debug add-on package: https://www.mediafire.com/folder/5grjk86k1pyyp/, just download anywhere into your desktop and drag into your firefox window to install it. It should appear with the name "CustomizableUI Debugger" in your add-ons manager afterwards. This won't interfere with your browsing at all, it just dumps some extra information to the browser console during startup, so you can just forget all about it until later when you go to uninstall it.
  • Please temporarily change your homepage to "about:home" or "about:newtab", this is to minimize the console messages from websites that usually flood it, which makes it discard the actual relevant messages during startup sometimes (this one may be an inconvenience I know, hopefully it won't be needed for very long).
  • If your corner toolbar is set to autohide, you'll either need to disable autohide, or create the habit of checking it on every startup to see if it has the icons or not. Which is to say, keep a sharp eye. :)

The next time this happens, do this immediately after the browser starts; try to memorize the shortcut if you don't know it already, so you don't need to come here, the less webpages you load before copying the console's contents the better (none is best):

  • Open the browser console (Ctrl+Shift+J) and copy all the contents of the console. It probably will be pretty large, so you'd better use pastebin.com (just paste here a link to it) or send me an e-mail with a text file of it.

After you've gotten the console's contents you can disable/remove the "CustomizableUI Debugger" add-on and restore your homepage.

Hopefully the console's log will be enough so that I can figure this out.

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/Puzzle-Toolbars/issues/58#issuecomment-63235114 .

Quicksaver commented 9 years ago

I'm so sorry, I don't know how that happened. This is the correct link: http://www.mediafire.com/download/nb4h8br6kuw9dii/CUIDebug@quicksaver.xpi

paulderdash commented 9 years ago

Hi

Have a look at this: http://pastebin.com/jZ56srJt

Hope you can see something ... I did got to a site before I noticed the icons were gone from the Puzzle Toolbar ...

Paul

On 17 November 2014 16:25, Luís Miguel notifications@github.com wrote:

I'm so sorry, I don't know how that happened. This is the correct link: http://www.mediafire.com/download/nb4h8br6kuw9dii/CUIDebug@quicksaver.xpi

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/Puzzle-Toolbars/issues/58#issuecomment-63311300 .

Quicksaver commented 9 years ago
paulderdash commented 9 years ago

On 22 November 2014 at 14:38, Luís Miguel notifications@github.com wrote:

-

What firefox version and operating system are you on?

Did you modify that log file in any way? There are no "Saved state" entries anywhere, and that's a bit weird as I always have plenty of those in my logs. Here's the problem I'm seeing: "Restoring puzzleBars-corner-bar from default state"; that should read "... from saved sate". This means that the toolbar's placements are just gone, and if this is happening during startup the "Saved state" entries would help as they contain a copy of the saved state (and hence the toolbar's placements) with them, so I could pinpoint more precisely when the toolbar's placements are being lost.

Could you go to about:support and give me your extensions list please? Another cause could be the toolbar's state is not being properly saved in the last session (as in the last time you had firefox open). And this is probably because of a conflict with another add-on, which is why I'd like to look at your extensions list, so I can look in their code to try and find a likely culprit. Can you tell if you do anything special in the session before the toolbars icons are lost, something in the browser or having to do with another add-on? Of course I understand this is a very difficult question, as you can do a million things in the browser, so if you can't think of anything then it's ok and I'll try to find the cause in another way.

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/Puzzle-Toolbars/issues/58#issuecomment-64078963 .

Quicksaver commented 9 years ago

so I don't expect you to find / debug this!

I will still try my best! :)

Quicksaver commented 9 years ago

Just by checking those add-ons I don't see any likely culprit...

Let's try this from another angle, which icons are in your corner toolbar? Do you always re-customize with the same icons after it loses them?

paulderdash commented 9 years ago

Hi Luis - below are the add-ons in my Corner toolbar ... yes, I always repopulate with same.

Adblock Plus 2.6.6 Add-on Update Checker 2.8 BetterPrivacy 1.68 true Extension Options Menu 2.10beta2 FEBE 8.0.5 NoScript 2.6.9.4 Privacy Badger Firefox 0.2.3 Restartless Restart 9 Self-Destructing Cookies 0.4.7-pre2 Xmarks 4.3.5

I will continue to look for a pattern. I had thought it might be a force restart without closing the browser, but I don't think that is it. It is probably just some peculiarity on my laptop.

On 23 November 2014 at 13:22, Luís Miguel notifications@github.com wrote:

Just by checking those add-ons I don't see any likely culprit...

Let's try this from another angle, which icons are in your corner toolbar? Do you always re-customize with the same icons after it loses them?

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/Puzzle-Toolbars/issues/58#issuecomment-64114622 .

paulderdash commented 9 years ago

I thought I had tested this but after (two) further tests, it does appear to happen if I restart my machine without quitting the browser first ...

On 23 November 2014 at 13:22, Luís Miguel notifications@github.com wrote:

Just by checking those add-ons I don't see any likely culprit...

Let's try this from another angle, which icons are in your corner toolbar? Do you always re-customize with the same icons after it loses them?

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/Puzzle-Toolbars/issues/58#issuecomment-64114622 .

Quicksaver commented 9 years ago

Sorry about the lack of activity here, it's been a busy couple of weeks.

Restarting the computer without quitting the browser doesn't seem to do it for me, I've tried restarting a few times now in many different conditions and the icons are always kept.

I'm going to try moving those exact add-ons into my toolbar and see if it loses positions at any time, but I've tried almost all of them at one point in the past, but it's never done that for me.

By the way, firefox 34 was just released, so let me know if by some sort of magic this doesn't happen anymore with it, although I doubt it.

paulderdash commented 9 years ago

No problem.

It did happen again now on 34.0.5. It must be some peculiarity in my FF profile; I just right-click and re-add them in 'Customize' when it happens, for now.

On 4 December 2014 at 01:09, Luís Miguel notifications@github.com wrote:

Sorry about the lack of activity here, it's been a busy couple of weeks.

Restarting the computer without quitting the browser doesn't seem to do it for me, I've tried restarting a few times now in many different conditions and the icons are always kept.

I'm going to try moving those exact add-ons into my toolbar and see if it loses positions at any time, but I've tried almost all of them at one point in the past, but it's never done that for me.

By the way, firefox 34 was just released, so let me know if by some sort of magic this doesn't happen anymore with it, although I doubt it.

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/Puzzle-Toolbars/issues/58#issuecomment-65509115 .

Quicksaver commented 9 years ago

BTW you have Extension Options Menu 2.10 available already in case it's not updating automatically from your beta version.

Quicksaver commented 9 years ago

Also, does BetterPrivacy prompt you on every firefox exit or did you disable that? (It's irrelevant if you set it to delete cookies or not, only the actual prompt should matter.)

Quicksaver commented 9 years ago

I've tried installing all your add-ons and placing the same icons in the toolbar, to try and replicate your profile, but after many firefox restarts and shutdowns and a few computer restarts without quitting firefox, the icons stay there.

Would you be willing to try creating a new profile, you can keep most of your personal data, but that does mean you would have to re-configure most of your add-ons at least, which means it would take a little more than a few minutes to do this. So I understand if it's not something you can't do so soon.

paulderdash commented 9 years ago

Hi Luiz

I am actually working with a relatively new profile, with the add-ons created afresh.

I can retry this - but give me some time ...

Paul

On 4 December 2014 at 12:31, Luís Miguel notifications@github.com wrote:

I've tried installing all your add-ons and placing the same icons in the toolbar, to try and replicate your profile, but after many firefox restarts and shutdowns and a few computer restarts without quitting firefox, the icons stay there.

Would you be willing to try creating a new profile, you can keep most of your personal data https://support.mozilla.org/en-US/kb/recovering-important-data-from-an-old-profile, but that does mean you would have to re-configure most of your add-ons at least, which means it would take a little more than a few minutes to do this. So I understand if it's not something you can't do so soon.

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/Puzzle-Toolbars/issues/58#issuecomment-65612870 .

Quicksaver commented 9 years ago

Of course, no worries. :)

Quicksaver commented 9 years ago

Good news is, if this is really the same bug as https://github.com/Quicksaver/OmniSidebar/issues/55, from my debugging there I'm almost sure this is just another symptom of another bug I found some time ago in firefox's customization system, which I have already reported to mozilla and they have already fixed.

Kinda bad news is, this is only fixed from firefox 35 onwards. Unfortunately there's nothing I can do within the add-on to keep the icons from disappearing like that. So you'll have to either be patient and wait for about a month and a half until firefox 35 is released, or you can install firefox beta for now, and revert back to the normal release channel when 35 is released.

paulderdash commented 9 years ago

Wow - fascinating! I am not that technical but I admire your persistence!

I will go to FF Beta and run that for a while (at least till it is officially released) and see if the problem, intermittent as it is, disappears - using current Puzzle Toolbars 2.0.1b4.

On 7 December 2014 at 15:04, Luís Miguel notifications@github.com wrote:

Good news is, if this is really the same bug as Quicksaver/OmniSidebar#55 https://github.com/Quicksaver/OmniSidebar/issues/55, from my debugging there I'm almost sure this is just another symptom of another bug https://bugzilla.mozilla.org/show_bug.cgi?id=989338 I found some time ago in firefox's customization system, which I have already reported to mozilla and they have already fixed.

Kinda bad news is, this is only fixed from firefox 35 onwards. Unfortunately there's nothing I can do within the add-on to keep the icons from disappearing like that. So you'll have to either be patient and wait for about a month and a half until firefox 35 is released, or you can install firefox beta https://www.mozilla.org/en-US/firefox/channel/#beta for now, and revert back to the normal release channel when 35 is released.

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/Puzzle-Toolbars/issues/58#issuecomment-65936712 .

paulderdash commented 9 years ago

Luis - so far, so good! I am pretty confident that the problem has been fixed in FF 35 beta.

On 7 December 2014 at 15:04, Luís Miguel notifications@github.com wrote:

Good news is, if this is really the same bug as Quicksaver/OmniSidebar#55 https://github.com/Quicksaver/OmniSidebar/issues/55, from my debugging there I'm almost sure this is just another symptom of another bug https://bugzilla.mozilla.org/show_bug.cgi?id=989338 I found some time ago in firefox's customization system, which I have already reported to mozilla and they have already fixed.

Kinda bad news is, this is only fixed from firefox 35 onwards. Unfortunately there's nothing I can do within the add-on to keep the icons from disappearing like that. So you'll have to either be patient and wait for about a month and a half until firefox 35 is released, or you can install firefox beta https://www.mozilla.org/en-US/firefox/channel/#beta for now, and revert back to the normal release channel when 35 is released.

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/Puzzle-Toolbars/issues/58#issuecomment-65936712 .

Quicksaver commented 9 years ago

I'm glad to hear it! I'll close this issue when Firefox 35 is released (since this is still a problem in the current version 34). Let me know if this changes or if you run into any other issues in the meantime.

Quicksaver commented 9 years ago

Firefox 35 has been released, so this shouldn't happen anymore. Please open a new issue (or re-open this one) if it ever happens again.

paulderdash commented 9 years ago

Hi Luiz

I know this is a long time ago ... I removed "CustomizableUI Debugger" add-on, but I still have 'Debug' option against some extensions. Could it be due to this add-on, and/or do you know how to remove that option?

I see devtools.chrome.enabled is set to true. Should I set this to false?

Best regards - Paul

On 16 November 2014 at 21:43, Luís Miguel notifications@github.com wrote:

Ok, so this may take a little bit of an effort, so I apologize in advance, but this doesn't happen to me at all, I've had Puzzle Toolbars installed pretty much since day one and it's never lost any icon.

Here's what you need to do right now:

  • Install the latest beta version 2.0.1b1 of Puzzle Toolbars at https://addons.mozilla.org/firefox/addon/puzzle-toolbars/versions/, this is only to make sure you have the latest code, closest to mine
  • Install this little debug add-on package: https://www.mediafire.com/folder/5grjk86k1pyyp/, just download anywhere into your desktop and drag into your firefox window to install it. It should appear with the name "CustomizableUI Debugger" in your add-ons manager afterwards. This won't interfere with your browsing at all, it just dumps some extra information to the browser console during startup, so you can just forget all about it until later when you go to uninstall it.
  • Please temporarily change your homepage to "about:home" or "about:newtab", this is to minimize the console messages from websites that usually flood it, which makes it discard the actual relevant messages during startup sometimes (this one may be an inconvenience I know, hopefully it won't be needed for very long).
  • If your corner toolbar is set to autohide, you'll either need to disable autohide, or create the habit of checking it on every startup to see if it has the icons or not. Which is to say, keep a sharp eye. :)

The next time this happens, do this immediately after the browser starts; try to memorize the shortcut if you don't know it already, so you don't need to come here, the less webpages you load before copying the console's contents the better (none is best):

  • Open the browser console (Ctrl+Shift+J) and copy all the contents of the console. It probably will be pretty large, so you'd better use pastebin.com (just paste here a link to it) or send me an e-mail with a text file of it.

After you've gotten the console's contents you can disable/remove the "CustomizableUI Debugger" add-on and restore your homepage.

Hopefully the console's log will be enough so that I can figure this out.

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/Puzzle-Toolbars/issues/58#issuecomment-63235114 .

Quicksaver commented 9 years ago

That debug button is from the add-ons manager itself, it will exist on every listed restartless extension that you have, as long as you have the the respective add-on debugging preference enabled. CUIDebugger should have disabled those when you removed it, but it's possible something might have gone wrong and it may have forgotten to do so.

Please try going to about:config and switching to false the following preferences: browser.uiCustomization.debug devtools.chrome.enabled devtools.debugger.remote-enabled

paulderdash commented 9 years ago

That did it! Thanks Luis.

Paul

On 5 October 2015 at 10:38, Luís Miguel notifications@github.com wrote:

That debug button is from the add-ons manager itself, it will exist on every listed restartless extension that you have, as long as you have the the respective add-on debugging preference enabled. CUIDebugger should have disabled those when you removed it, but it's possible something might have gone wrong and it may have forgotten to do so.

Please try going to about:config and switching to false the following preferences: browser.uiCustomization.debug devtools.chrome.enabled devtools.debugger.remote-enabled

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/Puzzle-Toolbars/issues/58#issuecomment-145463762 .

Quicksaver commented 9 years ago

No problem. :)