Quicksaver / Puzzle-Toolbars

A Firefox that adds many toolbar choices to fully customize the browser window.
https://addons.mozilla.org/firefox/addon/puzzle-toolbars/
Mozilla Public License 2.0
19 stars 4 forks source link

QuickJava buttons erroneously red until refreshed #64

Closed blackwind closed 9 years ago

blackwind commented 9 years ago

When Firefox is first started, all QuickJava buttons added to a Puzzle Toolbar are erroneously red until refreshed (via QuickJava's right-click menu). This is possibly related to issue #44. Can we get a fix?

Quicksaver commented 9 years ago

Yep, already reported it to the developer. :) https://github.com/ThatOneGuyDotNet/QuickJava/issues/19

blackwind commented 9 years ago

Unfortunately, the developer told me via email he wouldn't do anything about it and to report the issue to you.

Quicksaver commented 9 years ago

Did they give you a reason? This is an issue that's much more easily fixed on QuickJava's side, not only because it's more direct to implement like that, but it affects other add-on's toolbars as well (including the menu panel in firefox).

blackwind commented 9 years ago

"This sounds like a problem with the third party toolbar you are using so I am unable to supply a fix. The buttons work fine with the "factory" toolbar as well as the Vertical Toolbar extension. Please contact the Puzzle Toolbars developer."

ThatOneGuyDotNet commented 9 years ago

QuickJava 2.0.6 should fix this issue and has been submitted for review.

To install 2.0.6 early visit this page: https://addons.mozilla.org/en-us/firefox/addon/quickjava/versions/

Thanks to @Quicksaver for the code snippet.

@blackwind, my appologies, I apparently have not been getting my email notifications from GitHub so I did not see the issue/code Quicksaver submitted until he emailed me directly about it. I will look into that.

blackwind commented 9 years ago

Confirmed fixed. Cheers!