search

Quicksaver / Puzzle-Toolbars

A Firefox that adds many toolbar choices to fully customize the browser window.
https://addons.mozilla.org/firefox/addon/puzzle-toolbars/
Mozilla Public License 2.0
19 stars 4 forks source link

In the location bar, buttons with `badged-button` class don't match other buttons #93

Closed blackwind closed 8 years ago

blackwind commented 8 years ago

As noted in the title, buttons with the badged-button class don't match the styling of other buttons in the location bar toolbar. One such add-on that uses this class is uBlock Origin. When placed in the location bar toolbar, its button appears to retain the standard toolbarbutton style, even when "Show the number of blocked requests on the icon" is disabled in uBO's settings.

The correct way to handle this would probably be for the offending add-on to remove the class when no longer used, but this isn't a practical solution for me as a user of Puzzle Toolbars, as uBlock isn't the only add-on I use that does this. As such, I'd love to see a fix on your end.

Quicksaver commented 8 years ago

I'll take a look, thanks for letting me know.

Quicksaver commented 8 years ago

It seems to look ok to me, can you send me a screenshot of how it looks to you? What operating system are you on?

Quicksaver commented 8 years ago

Also please try beta version 2.1.15b1 and let me know if it makes any difference.

blackwind commented 8 years ago

With badged-button class:

with

Without:

without

Running Windows 10 with this theme and the default Firefox theme. The beta didn't help.

Quicksaver commented 8 years ago

Hmm, are you sure it's the default Firefox theme? Does it also appear like that if you disable all other add-ons except for Puzzle Bars, and of course uBlock Origin?

I ask because the add-on doesn't really style the buttons based on any themes at all, it should just style the buttons all the same regardless.

blackwind commented 8 years ago

Hmm, are you sure it's the default Firefox theme?

100% sure.

Does it also appear like that if you disable all other add-ons except for Puzzle Bars, and of course uBlock Origin?

I just tested in a fresh profile with only those two add-ons, and I'm still able to reproduce.

I ask because the add-on doesn't really style the buttons based on any themes at all, it should just style the buttons all the same regardless.

It should, but it seems to be ignoring buttons with that particular class. Or the rules for that class are overriding your rules.

Quicksaver commented 8 years ago

Alright I think I figured it out. Please try beta version 2.1.15b2 and let me know how it looks for you.

blackwind commented 8 years ago

Only difference appears to be that you've changed the styling to match the corner toolbar. Buttons with the badged-button class still show the standard toolbar styling on top of your styling -- it's just slightly less noticeable this way until you click them. This new styling also makes my HTTPS Everywhere button look weird due to their silly toolbarbutton-within-a-toolbarbutton approach.

Quicksaver commented 8 years ago

Made some tweaks to beta version 2.1.15b3, both badge buttons and the HTTPS Everywhere button should look better now.

blackwind commented 8 years ago

Perfect. Great work!

If I could make a suggestion for your next task, with Fx50 hitting the stable channel soon, Quicksaver/FindBar-Tweak#263 should be a top priority.