Quicksaver / Tab-Groups

Reimplementation of Firefox Tab Groups as an add-on.
https://addons.mozilla.org/firefox/addon/tab-groups-panorama/
Mozilla Public License 2.0
547 stars 73 forks source link

lost all tabs except the active tab, at windows startup #219

Open zefilipe opened 8 years ago

zefilipe commented 8 years ago

Hi !

I have at my work: Windows 7 professional 32 bits Firefox 46.0.1 Tab Groups 2b9

Every day, when i press CPU power on, and wait starting windows, after startup, when i open Firefox, i lost all my tabs except the active tab, and all other shows as about:blank :-(

Every day, i hat a lot of work tabs, that i use daily ... and will be daily restore tabs with Session Manager, for a litle days ok, but if its so mutch days its bad :-(

But if i restart firefox (without shut down windows), all the tabs loads ok, and i dont lost any tab .. !

Please fix this, or give me tips to fix it ! Regards

Quicksaver commented 8 years ago

Are you closing Firefox before you shut down windows? The shutdown may be preventing your session from saving properly and could become corrupted.

Or you could have some other add-on corrupting the session somehow. Have you tried installing Tab Groups in a clean profile and see if the tabs are properly restored then?

zefilipe commented 8 years ago

Hi !

Of course i close Firefox before shut down windows !

I'm a advanced user, and i dont thing that will be any addon corrupted, lastest installed is tab groups, and before mozilla announces the end of panorama, everything works ok, and i do not lost any tab ... !

Related to tabs i have the addons: Private tab Tab groups Tab groups helper TooManyTabs Unload Tab

One of these addons may be conflict with tab groups ? Howto fix it ? If its a bug, please fix it !

If i create a clean profile, i can later change default profile, to this profile agains, unless the new clean ?

Regards

Quicksaver commented 8 years ago

i dont thing that will be any addon corrupted, lastest installed is tab groups, and before mozilla announces the end of panorama, everything works ok

Tab Groups is now in an add-on, so it's possible there's an incompatibility with one of your current add-ons, even if it worked well before. Which is why I asked you to try in a clean profile, to rule that out at least.

If i create a clean profile, i can later change default profile, to this profile agains, unless the new clean ?

Yes you can, you can always go back to your current profile unless you explicitly delete it. See the link I gave you.

Quicksaver commented 8 years ago

You can also see if the same happens with beta version 2b9. Note that the changes in that beta are extensive from the current release, so it's definitely worth it giving the "How to use" page in the preferences a read, to get acquainted with the new features.

Quicksaver commented 8 years ago

Please reopen if this keeps happening with the beta version I linked above.

zefilipe commented 8 years ago

Hi !

Escuse me, but with so mutch work, i dont had time to create new profile or take tests disabling addons .. ! :-(

Tomorow, i tried disable addon UnloadTab https://addons.mozilla.org/pt-PT/firefox/addon/unloadtab/?src=api

And Today morning after started windows 7, i opened Firefox, and it's ok, with all my tabs i worked tomorrow ! ;-)

But the features implemented by UnloadTab its necessary, to hibernate unused tabs, and spent less memory and resources ... !

I Think that TabGroups will be implement this feature, or i can use this or other related addon, to unload unecessary tabs ... !

Regards

eMBee commented 8 years ago

i seem to have run into the same problem. i have hundreds of tabs, and after restating, a few dozend are empty. looking at it, it appears to be all tabs that the "unload tab" extension unloaded after timeout.

interestingly, some of the tabs keep their favicon, but everything else is lost.

it appears not to affect tabs that were unloaded manually.

cesarizu commented 8 years ago

I've disabled all other addons but this is still happening to me. All tabs are blank after restarting the browser.

Quicksaver commented 8 years ago

Those using UnloadTab, could you please try Auto Unload Tab or Suspend Tab instead? UnloadTab hasn't been updated in over two years, and it apparently has problems by itself, it seems pretty much abandoned. Both Auto Unload Tab and Suspend Tab are much more recent, and I don't believe I've ever received any reports about problems with either.

@cesarizu note that just by disabling UnloadTab you won't be able to get your tabs back if they have already been unloaded and you have restarted the browser since. You'll have to either import them back from a backup or open them again altogether. What I'm asking for is to see if either of those add-ons causes you to lose tabs that you know have been loaded at least once at any point since installing it.

cesarizu commented 8 years ago

@Quicksaver I've had UnloadTab and any other tab related addons disabled for some weeks now, but it is still happening every time I start firefox.

I can usually recover the tabs from the "last session" or a saved backup in the tab-groups settings. If I try to recover to the same window I started with, I only get more blank tabs. But if I open a new window (ctrl-shift-n) and I recover the tabs there, the tabs are recovered correctly.

To be more specific: After closing and opening Firefox normally (no crash), only the last opened group tabs are recovered, but as blank tabs. Pinned tabs are recovered correctly. When I open tab-groups overview (ctrl-shift-e) I get the list of groups, but no tabs whatsoever, not even the blank tabs from the current group.

Is there anyway I can debug this issue to try to figure out what's going on?

Quicksaver commented 8 years ago

That's very weird. Let's start with the most obvious, can you please try installing Tab Groups in a new profile and see if it still happens there?

cesarizu commented 8 years ago

Mmmh it worked. I started disabling other extensions and it seems that keefox is the one causing problems, even though it doesn't have to do anything with tabs.

When the tabs are not loaded, I see in the console the following messages repeated several times:

console.log: TypeError: tab.extData is undefined

###!!! [Child][MessageChannel] Error: (msgtype=0x460112,name=PContent::Msg_AsyncMessage) Channel closing: too late to send/recv, messages will be lost

EDIT: keefox by itself is working correctly, so it's some sort of conflict between the two extensions.

Quicksaver commented 8 years ago

console.log: TypeError: tab.extData is undefined

Does it say in which file and line? extData is where the groups information is stored, i.e. to which group does a specific tab belong to. So it's no surprise you're not seeing your tabs in your groups.

I installed KeyFox and KeyPass, gave it a small trial run and everything seems to work fine for me, I get all my tabs from all my groups back after closing and restarting Firefox. Although I admit I haven't fully configured it (there are so many options...).

I checked KeyFox's code and couldn't find anything related to Firefox's session management either. It's entirely possible it's KeyPass itself modifying your session file after Firefox closes / before it opens, in which case it's completely outside anything I could do from within the add-on. It's also entirely possible I just missed it in KeyFox's code too... :(

Could you please contact KeeFox's developers about this? Since I can't reproduce this, it's probably best coming from you in case they need more info that I can't provide. You're welcome to link them here, I'd be more than happy to make any changes necessary to Tab Groups to fix this, but I need to know what's actually happening.

cesarizu commented 8 years ago

Thanks. I'm going to try to debug this a bit more to see what I find and then contact them.