Quicksaver / Tab-Groups

Reimplementation of Firefox Tab Groups as an add-on.
https://addons.mozilla.org/firefox/addon/tab-groups-panorama/
Mozilla Public License 2.0
544 stars 73 forks source link

Tab-Groups doesn't work with current Firefox Tab Center 1.22 #375

Closed gusowski1 closed 7 years ago

gusowski1 commented 8 years ago

If the Firefox Expirement Tab-Center https://testpilot.firefox.com/experiments/tab-center is enabled, the Tab-Groups doesn't work anymore

iShyboy commented 8 years ago

Talk a bit more about this, I'm using FF 47.0.1 and Tab Center 1.22 with latest TG and it's working fine. Just that my TG icon was in the tab bar when I added Tab Center so I had to tap restore on Customize menu to TG buttom get back to the buttons box. But the shortcut and the rest worked fine even before.

gusowski1 commented 8 years ago

hm - the Tab Group itself is displayed and the tab in the groups to - but all tabs of the other tab-groups to

probaly i should try the nice disable all and enable only some addons to track the issue down

iShyboy commented 8 years ago

Oh, I saw that too, but in a odd way, the tabs of other groups appeared on the actual group totally at random, and disappeared too. And I only have TG, Tab Center and uBlock Origin.

gusowski1 commented 8 years ago

oh ok - then it is an issue and i doesn't need to try this enable/disable game

Quicksaver commented 8 years ago

I'll have to check it out. If I understood correctly, all tabs (from other groups as well) are always visible, is that it?

Quicksaver commented 8 years ago

For reference: https://github.com/bwinton/VerticalTabs/issues/424

talha131 commented 8 years ago

@Quicksaver here are few images to explain the issue.

There are the tabs I have in group 1

screen shot 2016-08-10 at 08 39 33

Now say I move to all tabs group page using ⌘Command+⇧Shift+E key, and then press ⎋Escape without clicking anywhere. Tabs from all the groups appear in the sidebar.

screen shot 2016-08-10 at 08 37 25

The only way I can get back the filtered list i.e. tabs of only group 1, is by going into tabs group selection page and there clicking on a tab from group 1.

I am using Firefox 48.0 (Build ID 20160726073904) on OS X 10.11.6 with Tab Groups 2.0.1.

Please let me know if you need more info to reproduce the issue. I can upload a video if you feel necessary.

febcrash commented 8 years ago

Same problem here! All tabs are displayed (no group) with Firefox Tab Center 1.23 (Test Pilote)

rahiel commented 8 years ago

Same problem here!

If it helps anyone: I've switched from the Tab Center experiment to the Vertical Tabs Reloaded add-on, which is compatible with tab groups.

Turkal commented 7 years ago

I have the same problem with TabCenter 1.24

Actually, just pressing the Escape key show all the tabs from all groups.

Quicksaver commented 7 years ago

Beta version 2.1b2 should fix compatibility with Tab Center, only tabs from the current group should be shown, and the groups button should now be visible again in the tabs toolbar as well. Please give it a try and let me know how it works for you.

Dimas-sc commented 7 years ago

It works for me, thx!

Quicksaver commented 7 years ago

Great! Thanks for letting me know.

Turkal commented 7 years ago

Same here, everything works fine now. Thanks !

jeanblanchard commented 7 years ago

Here it works fine when the sidebar is locked, but all tabs are shown as soon as it is shrinked.

Edit: actually, even with a locked sidebar, when a tab is opened in the background, it shows all tabs. It is fixed once the tab is focused.

Edit2: Well, after restarting Firefox a few times, the issue appears to be gone. Everything seems the be working great now :)

Quicksaver commented 7 years ago

@jeanblanchard The last version of Tab Center was released just a few days ago, so it's possible you could have been using an older version of Tab Center that got updated in the meantime. Please let me know if it starts happening again.

jeanblanchard commented 7 years ago

@Quicksaver I updated manually to the 2.1b3 version. Maybe the hot update missed something that was fixed by doing a platform restart ?

Quicksaver commented 7 years ago

It's possible but I doubt it, and I meant that about Tab Center, not Tab Groups.

jeanblanchard commented 7 years ago

Oh right, it appears my brain cannot distinguish between "Tab center" and "Tab groups". Indeed Tab Center was last updated today in my Firefox, so it must be that. (sorry everyone about the notification spam)