Not keeping the correct active tab in a group after importing from backups

[Quicksaver]

Originally posted by @iG8R at https://github.com/Quicksaver/Tab-Groups/issues/495#issuecomment-262208734

But I noticed some strange behavior after restoring a group. E.g. I have following already launched groups: Group 1 (1 2 3 4 5 6 7 8 9 Tabs) - active group with active tab #5 Group 2 (1 2 3 4 5 6 7 8 9 Tabs) Group 3 (1 2 3 4 5 6 7 8 9 Tabs) After restoring Group 1 (1 2 3 4 5 6 7 8 9 Tabs) - active group with active tab #5 Group 1 (1 2 3 4 5 6 7 8 9 Tabs) (yes, this group has the same name as the first one, lets mark it with asterisk) Group 2 (1 2 3 4 5 6 7 8 9 Tabs) Group 3 (1 2 3 4 5 6 7 8 9 Tabs) Then I switch from Group 1 with active tab 5 to Group 1 and 1st tab of this group is become active. After this I return to Group 1 and tab #1 become active not tab #5.

Tab 5 was active only in "Group 1", in "Group 1*" tab 1 was active before backing up.

[Quicksaver]

I take it that Group 1* was imported from a backup of Group 1. What was the active tab at the point Group 1 was backed up?

For example, if tab x in Group 1 is active when the backup is created, then importing it back will create Group 1* still with tab x active, regardless of what the active tab in Group 1 currently is.

This is the behavior I'm seeing, I'm not seeing what you mention at all. How are you switching groups? Can you give me the specific steps you are using in a clean profile to reproduce this? If possible, can you attach here a backup file that gives you this issue so I can take a look at it?

[iG8R]

Group 1 is absolutely different to the Group 1, only their names are the same. Before backing up Group 1 had the active tab 1.

For example, if tab x in Group 1 is active when the backup is created, then importing it back will create Group 1* still with tab x active, regardless of what the active tab in Group 1 currently is.

Yes, I'm expecting and observing the same behavior. But the issue is with existing Group 1. I do the following steps (initial conditions - Group 1 with the active tab 5):

1. Restoring Group 1*(the same name, I've marked it with an asterisk to somehow distinguish it) which had active tab 1 before backing up.
2. Then I switch from Group 1 (with active tab 5) to Group 1* (with active tab 1).
3. Eventually I return from Group 1* (with active tab 1) to Group 1 not to previously active tab 5 but to tab 1.

[Quicksaver]

I am not seeing that at all, tab 5 keeps its active status when I switch back to that group.

By steps, I meant exactly clicks and keypresses. As in, how are you switching groups, through the keyboard shortcut? The quick access panel? Going into and out of groups view?

By "eventually", what happens in between? Do you do anything? Do you switch immediately back and forth?

[Quicksaver]

Does tab 1 in group 1 somehow grab focus while you're in group 1*? Does it open any popup or warning? Does it load another webpage?

[iG8R]

I click on the button in the right upper corner next to Firefox tabs near Close button. Then in the drop-down menu I select required group. I switch immediately.

[iG8R]

Does tab 1 in group 1 somehow grab focus while you're in group 1*? Does it open any popup or warning? Does it load another webpage?

Nothing you mentioned happens.

[Quicksaver]

When you import Group 1*, are you in Group 1? Or in other words, is group 1 tab 5 the add-on's options page you use to import?

[iG8R]

When you import Group 1*, are you in Group 1? Or in other words, is group 1 tab 5 the add-on's options page you use to import?

Yes. During back up I'm in Group 1 tab 5.

[Quicksaver]

What Firefox version and operating system are you on?

[iG8R]

Windows 8.1 Pro 64bit, Windows 10 Pro 64bit Firefox 50.0 64bit

[Quicksaver]

I'm sorry, I'm not doubting that you have this issue, but I can't reproduce it at all, I stay on the correct tab when I switch back to the previous group. I have to ask, are you absolutely sure this is happening in a clean profile?

[Quicksaver]

Do you have any pinned tabs?

[iG8R]

Yes, I use absolutely clean profile. No, I don't have any pinned tabs among 752 ones :)

[Quicksaver]

How are you testing in a clean profile? Are you creating groups with random tabs just to see if their active tab remains or are you using the same backup from your current profile to import into the new profile?

[iG8R]

I made absolutely clean profile, then I installed TabGroups and copied only a backup file from my main profile and nothing else.

[Quicksaver]

... I don't get it, there's just no reason for why it should behave like that.:frowning:

Is there any chance I could ask you for your backup file? I'd like to check it out myself if possible. You can send it to my e-mail directly if you prefer: quicksaver@gmail.com