search

Quicksaver / The-Fox--Only-Better

A Firefox add-on to improve the feeling of using the new Australis theme.
https://addons.mozilla.org/firefox/addon/the-fox-only-better/
Mozilla Public License 2.0
91 stars 22 forks source link

Slim Chrome Rendering With Menu Bar Disabled And On Flash Pages #106

Closed Techy-Ben closed 9 years ago

Techy-Ben commented 9 years ago

Okay, these should be the last two issues from me for awhile. First, I hid my menu bar in order to make Firefox slimmer and look better, and when I did that caused the background alignment in slim chrome to break between the navigation toolbar and the bookmarks toolbar. I expected that, so I disabled/reenabled slim chrome, but the background was still slightly misaligned. I all my other add-ons, but the background was still misaligned. It's hard to see in a screenshot, so I made a video of it: http://youtu.be/KhHkjfwUGxs. (Private Video) Using slim chrome in Full Width mode solves the problem, and the other style options affect the alignment to different degrees.

The other problem occurs on flash pages like pixlr.com/editor. This may not be a bug, but may rather be inherent on flash pages. slim chrome draw issue

Quicksaver commented 9 years ago

so I made a video of it: http://youtu.be/KhHkjfwUGxs. (Private Video)

You do know that if you make it private I'm not able to see it even if I have the link, right? ;) Anyway, the backgrounds are fine for me, so I guess I might really need that video...

The other problem occurs on flash pages like pixlr.com/editor. This may not be a bug, but may rather be inherent on flash pages.

That's because of the fix I put in place for #53. It's also one of the things that can only be fixed once e10s arrives (hopefully), so I'll have to wait until then to do anything about it.

Techy-Ben commented 9 years ago

Oops, sorry, I couldn't remember which setting allowed viewing of the video with the link only. I changed the video to unlisted, so you should be able to see it now. Also, try looking at the eagle's beak--that's where it's most obvious.

Quicksaver commented 9 years ago

That's weird, themes look fine for me, including that one. Could you try the add-on and the theme in a new profile and see if it also appears misaligned? If it does, you'll have to once again narrow down the cause in your main profile (other add-ons, buttons, stylesheets, etc).

Techy-Ben commented 9 years ago

Yes, in a new profile with no settings changed and no add-ons other than TFOB and the theme Celebrate Americas Symbol, I still have the misalignment issue. Did you try these settings in TFOB? tfob settings

Also, I have the Menu Bar disabled, Navigation Toolbar and Bookmarks Toolbar enabled, and the Bookmarks Toolbar is the only one deploying Slim Chrome.

I'm not sure what settings I could narrow it down too, since I replicated the issue in a completely clean profile...

Quicksaver commented 9 years ago

I made some changes to the way the background image is placed. Can you tell if beta 10 (https://github.com/Quicksaver/The-Fox--Only-Better/releases/tag/v1.1.14b10) helps at all with this?

Techy-Ben commented 9 years ago

No, I still have the same issue, unfortunately.

Quicksaver commented 9 years ago

The theme background issue? As the one in flash pages is impossible to fix at the moment like I said.

Quicksaver commented 9 years ago

Hmm, I do see the issue in Firefox 38 (current release) but I don't see it in Firefox 39 (beta). Seeing as Fx39 is less than a week away from being released, I don't think it's necessary to fix this, it wouldn't make it in time for 38 anyway.

Let me know if you still have the issue when your firefox updates and I'll take another look.