Quicksaver / The-Fox--Only-Better

A Firefox add-on to improve the feeling of using the new Australis theme.
https://addons.mozilla.org/firefox/addon/the-fox-only-better/
Mozilla Public License 2.0
91 stars 22 forks source link

Maybe searches in urlbar should respect the browser.search.openintab #153

Open yfdyh000 opened 8 years ago

yfdyh000 commented 8 years ago

If the pref-showOnlyNonEmptySearchBar is enabled. Or, add a option?

Quicksaver commented 8 years ago

When the search comes from the location bar, it should still obey location bar rules, that preference is for the search bar, not for searches in general (for instance you can search from the location bar even without the add-on, and it still doesn't obey pref as expected). I'd rather leave the location bar's behavior as-is.

You can use an add-on like Tab Mix Plus to always open new tabs from the location bar if you want. You can also ctrl+left click or middle click the go button or a suggestion in the panel, or press alt+enter; all of those will open in a new tab by default.

yfdyh000 commented 8 years ago

Yes, I understand the reason. But, I hope opens urls in the current page and open a new tab for search results always.

Can you add an option or pref to respect it for urlbar searches always when search bar has disappear. Either, respect it if the focus source is Ctrl+K and things like that, although it may be confusing.

Quicksaver commented 8 years ago

There are two main reasons I feel strongly about not doing this:

respect it if the focus source is Ctrl+K and things like that

Definitely not, that's even worse. Different outcomes should come either from different places or from different actions, not from how you got to those places; i.e. typing in the location bar is typing in the location bar, it doesn't matter how you started typing there.

If I were to add this option, it would respect all search actions from the location bar, regardless of any other preferences, of how the location bar was focused, etc.

yfdyh000 commented 8 years ago

Um, it seems there is no way to my needs, searches open in a new tab always and open urls is not affected?

Quicksaver commented 8 years ago

Not unless I can find a "safe" way to do it. I'll check this out again either later or tomorrow, but I really can't make any promises.

Quicksaver commented 8 years ago

I'm reopening to remind me to check it out again at a later time. I'll still try to do something about it eventually, but I have to put it in the backburner at least for a while, I hope you understand.

yfdyh000 commented 8 years ago

I understand. Thanks for your efforts for a better future.