Quicksaver / The-Fox--Only-Better

A Firefox add-on to improve the feeling of using the new Australis theme.
https://addons.mozilla.org/firefox/addon/the-fox-only-better/
Mozilla Public License 2.0
91 stars 22 forks source link

Enhanced "Awesome Bar" suggestions not working properly in Firefox 48 #188

Closed ces42 closed 7 years ago

ces42 commented 8 years ago

Firefox 48 changed the layout of the "Awesome Bar" suggestions and this seems to affect this add-on. (see attached Screenshot). The main problem is that there were more than one suggestions, but only one was partly displayed.

bug-beyond_australis

Riajyuu commented 8 years ago

Same for me but just using 49 beta. But for me, it is going black.

Quicksaver commented 7 years ago

I'm sorry it took me so long to get to this. This should be fixed by beta version 1.4.7b1. Please try it out and let me know how it works for you.

ces42 commented 7 years ago

well, it works better, although there is still to little space below site addresses. firefox

Quicksaver commented 7 years ago

Do you have any special styles being used, such as Stylish scripts or anything in your userChrome.css? Does that also happen if you disable all other add-ons except for Beyond Australis?

ces42 commented 7 years ago

still the same with addons and userchrome disabled

Quicksaver commented 7 years ago

Does that also happen in a clean profile? I can't reproduce it at all, it looks as supposed for me.

ces42 commented 7 years ago

still the same with a clean profile - maybe its an ubuntu / unity thing?

Riajyuu commented 7 years ago

@ces42 it seems not. i'm using Firefox 51 beta (64-bits) on Windows 10. For me it looks like this: 20161119_084230 Here is my preferences: thefoxonlybetter-prefs-20161119-084158.zip @Quicksaver Can you give a look?

Quicksaver commented 7 years ago

@EMLVIRUS it's black, all of it? Does it look like that if you disable all your other add-ons and themes? What about on a clean profile?

Riajyuu commented 7 years ago

it should be an issue from such a CSS with TFOB "show search engines" enabled. 新建文本文档.txt

Quicksaver commented 7 years ago

@EMLVIRUS that code needs to be updated to deal with search engine icons existing in the location bar, I also have trouble with it in Nightly which also places the search engines there (regardless of Beyond Australis being enabled or not).

It's also definitely not the same as @ces42's issue.

For now you can add a #searchbar selector behind each line, so that it doesn't interfere. Something like this:

@namespace url(http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul);
/*
HELLO! This script has optional settings that you can try out if you return to its page: https://userstyles.org/styles/122214/firefox-search-bar-show-engine-names-firefox-43
*/
/* Make the one-off buttons span the full width */
#searchbar .searchbar-engine-one-off-item[tooltiptext] {
  width: 100% !important;
  height: 24px !important;
  background-image: none !important;
  padding-left: 6px !important;
  box-sizing: content-box !important;
  line-height: 1em !important;
}
/* Hide the empties */
#searchbar .searchbar-engine-one-off-item:not([tooltiptext]) {
  display: none !important;
}
/* Fix up borders */
#searchbar .searchbar-engine-one-off-item[tooltiptext], .addengine-item {
  border-bottom: 1px solid #ccc !important;
}
#searchbar .search-setting-button.search-panel-header, .addengine-item,
#searchbar .search-panel-header.search-panel-current-input {
  border-top: none !important;
  max-height: 26px !important;
  min-height: 16px !important;
  padding-top: 1px !important;
}
/* Insert descriptive name for search engine plugin */
#searchbar .searchbar-engine-one-off-item[tooltiptext]::after {
  content: attr(tooltiptext);
  margin: 5px 6px 0px !important;
  display: block !important;
}
/* Fix icon positioning */
#searchbar .searchbar-engine-one-off-item[tooltiptext] > .button-box {
  display: inline-flex !important;
  width: 16px !important;
  max-width: 16px !important;
  border: none !important;
  padding: 0 0 !important;
}
#searchbar .searchbar-engine-one-off-item[tooltiptext] > .button-box > .button-icon {
  display: block !important;
  margin-top: 4px !important;
  margin-left: -1px !important;
}
/* Lock in space for 5 search suggestions with scroll bar */
#PopupSearchAutoComplete .autocomplete-tree.plain.search-panel-tree .tree-bodybox,
#PopupSearchAutoComplete .autocomplete-tree.plain.search-panel-tree .autocomplete-treebody {
  display: flex !important;
  flex: 1 1 auto !important;
}
#PopupSearchAutoComplete .autocomplete-tree.plain.search-panel-tree .autocomplete-treebody {
  max-height: calc(5 * 1.5em) !important;
  min-height: calc(5 * 1.5em) !important;
}
#PopupSearchAutoComplete .autocomplete-tree.plain.search-panel-tree .tree-scrollbar[collapsed="true"] {
  visibility: visible !important;
}
/* User style options */
/* One column - standard spacing (built-in above) */
/* Hiding "Search for ..." */
#searchbar .search-panel-header.search-panel-current-input {
  display: none !important;
}
/* Not hiding "Add ..." engine */
/* Not hiding "Change Search Settings" */
/* Search bar tooltip text only visible on mouseover */
/* No color scheme */
Quicksaver commented 7 years ago

@ces42 what Firefox version are you on?

ces42 commented 7 years ago

I just switched to 50.0, but the issue still persists

Quicksaver commented 7 years ago

@ces42 I think I figured it out. Just to confirm, you have "Large Text" enabled in Ubuntu's settings, correct? Or at least some sort of custom text scaling set somewhere.

ces42 commented 7 years ago

Yes I have set text scaling to 1.15 in unity-tweak-tool. If I set it to 1.0 everything works fine.

Quicksaver commented 7 years ago

I believe beta version 1.4.7b2 should fix that. Please try it out and let me know.

ces42 commented 7 years ago

Yup, it works now. Thank you!

Quicksaver commented 7 years ago

Great! Thanks for letting me know. :)