search

Quicksaver / The-Fox--Only-Better

A Firefox add-on to improve the feeling of using the new Australis theme.
https://addons.mozilla.org/firefox/addon/the-fox-only-better/
Mozilla Public License 2.0
91 stars 22 forks source link

Slim chrome is not full width #195

Closed Keith94 closed 7 years ago

Keith94 commented 7 years ago

A conflict with "Tab Center" extension...

Steps to reproduce:

  1. Install TC: https://people.mozilla.org/~bwinton/TabCenter/tab-center.xpi
  2. Pin the TC sidebar using the toolbar button provided
  3. Resize the TC sidebar to be narrower using the splitter
  4. Set the slim chrome to "Full width" and hover the nav bar to reveal it

Notice when TC is pinned (+ the width is not at default), the left edge of the top chrome isn't calculated dynamically. When TC is unpinned, the chrome width looks as expected.

Keith94 commented 7 years ago

I don't think it's fixed. The toolbar's width seems to be fixed at a small size.. tested latest code from both addons.

firefox_2016-11-15_05-39-18

Quicksaver commented 7 years ago

Quite... how very peculiar...

Quicksaver commented 7 years ago

How about now? :)

Keith94 commented 7 years ago

Yes, that looks proper. Maybe slim chrome should also take into account when another sidebar is open at the same time (e.g. bookmarks sidebar)? Currently it overlaps the sidebar.

firefox_2016-11-15_08-32-36

Keith94 commented 7 years ago

I believe the slim chrome could use tweaking for Tree Style Tab as well. Currently there is a small gap between Tabs toolbar and slim chrome (you might need the splitter disabled):

firefox_2016-11-15_08-40-57

And when a sidebar is open, the width stays the same:

firefox_2016-11-15_08-45-04

In my opinion I would like to see the slim chrome expand the full width of the browser when using Tree Style Tab, since the tabs are positioned below the top toolbars anyway. Maybe an about:config preference could work for that?

Quicksaver commented 7 years ago

Yes, that looks proper. Maybe slim chrome should also take into account when another sidebar is open at the same time (e.g. bookmarks sidebar)? Currently it overlaps the sidebar.

Actually that's only happening in that case because of Tab Center, without that the toolbars appear over the sidebar as they should by default.

There is a preference in about:config to not cover the sidebars though: extensions.thefoxonlybetter.slimOnlyOverContent, I'll see if I can automate that in this case though, as of course it looks just silly like that.

Quicksaver commented 7 years ago

There we go. It should only show the toolbars over the webpage when using both Tab Center and Tree Style Tab. And with TST it should reach the edge/resizer/grippy much better.

By the way, please try to open different issues for things like those. I guess they are "kinda related" to the original post, but not really by that much. 😉

Keith94 commented 7 years ago

Okay, thanks for the fixes. :) I'll open a follow-up issue.