Quicksaver / The-Fox--Only-Better

A Firefox add-on to improve the feeling of using the new Australis theme.
https://addons.mozilla.org/firefox/addon/the-fox-only-better/
Mozilla Public License 2.0
91 stars 22 forks source link

Slider for sensitivity in Beyond Australis invisible #205

Open Termuellinator opened 7 years ago

Termuellinator commented 7 years ago

i noticed that the sliders for adjusting the sensitivity of the slim bar is invisible for me. you can still blind-click or use tab+arrow keys to adjust, but would be nice if it reappeared :)

Using FF49 on Manjaro-KDE x64 (package firefox-kde, but don't know exactly what is different there, i read something about mime-types) with radeonSI/mesa

Quicksaver commented 7 years ago

Were they visible before?

Quicksaver commented 7 years ago

Do the time and volume seekers in HTML5 videos appear correctly (see screenshot)? They're actually the same elements, only styled a little differently. The add-on doesn't really do anything to style the sliders, it just places them there and Firefox takes care of the rest.

firefox_2016-11-16_12-38-49
Termuellinator commented 7 years ago

I think they were visible somewhere in the (more or less) distant past, but i can't really tell for sure :/ HTML5 vids appear exactly as in your screenshot. I just switched GTK-Themes to rule that out as an issue - maia, breeze and adwaita all show the same behaviour. Also tried with the "firefox"-package, but i THINK the only difference to firefox-kde is the kmozillahelper-dep. I just looked at my other addons and the only one that has a slider in the settings is Omnisidebar (the transparency-slider) and it shows the same behaviour. Do you know any way to test the slider-style (or whatever its called ^^) independently so that i can perhaps report it to bugzilla/kde/whoever is resposible? screenshot_20161116_135948

Quicksaver commented 7 years ago

The problem is I don't believe the slider is used anywhere in Firefox, at all, except in those HTML5 videos (at least I don't find any other references to them anywhere in the code), well except for tests but those aren't built into Firefox builds.

Those should definitely appear using GTK though, at least they do for me. Have you tried disabling all your other add-ons and themes and even userstyles (do you have anything in your userChrome.css?) to see if they appear then?

Termuellinator commented 7 years ago

besides omnisidebar i have no other addons that should (imho) affect the UI. Reverting to the default-theme has no effect and i don't think i have any userstyles. i don't have a chrome subfolder and thus no userChrome.css - is this normal if i didn't create it or might this be causing the issue? O_o

Quicksaver commented 7 years ago

besides omnisidebar i have no other addons that should (imho) affect the UI.

Any add-on can in theory affect UI, even if that's not its main purpose, I've seen add-ons do the weirdest things just so everything works correctly. Even my own add-ons are full of little "tricks" that affect other areas of the browser so that everything works correctly. 😉

Giving it a try won't hurt, you can always re-enable your add-ons after checking of course.

i don't have a chrome subfolder and thus no userChrome.css - is this normal if i didn't create it or might this be causing the issue?

Yeah it's expected, that file won't exist until you create it (or until an add-on does it for you, although I don't think there are many out there that actually use it anymore). So, no that's not the cause either of course.

Quicksaver commented 7 years ago

Any add-on can in theory affect UI, even if that's not its main purpose,

As an example, not long ago I ran across an issue where a stylesheet created by an add-on to properly style its elements was affecting some of my add-on's as well, by pure coincidence. The two were hardly related at all.

Termuellinator commented 7 years ago

Ah ok, good to know :D But no, even with only Beyond Australis active (and restarted) the sliders are still missing. Just checked on my Windows-Laptop (which should have pretty much the same FF-config) and there the sliders are visible.

Quicksaver commented 7 years ago

Hmm, if you start Firefox with a new clean profile and install Beyond Australis in it, do they appear?

Quicksaver commented 7 years ago

Also, please try it with beta version 1.4.7b1 if you can, to see if it makes any difference (although I sincerely doubt it, but who knows).

Termuellinator commented 7 years ago

Now got time to try with new profile - still the same. Hadn't seen your beta-recommendation, will try it when i've got time. Also when i've got time i'll fire up a VM with clean KDE-install and see if its general or just my system ^^

Quicksaver commented 7 years ago

I just installed KDE environment in my Ubuntu and the sliders appear fine. I wonder if it's something specific to Manjaro, I'll try to run an instance to test on it as well.

Quicksaver commented 7 years ago

Alright it really is Manjaro-KDE after all. It appears that in some Firefox builds, in particular the one Manjaro uses, don't include the images used to style those sliders.

Good news: they already fixed it for Firefox 52. So when your Firefox updates to it (coming early next March), they should appear normally.

Bad news: there's really nothing I can do in the meantime, those images aren't included at all in that Firefox build, and I can't just include them in the add-on because I can't know from within the add-on if it's installed in a build without those (at least not easily), and replacing the default styling could potentially break other builds.

Quicksaver commented 7 years ago

For reference: bug 1305701

Termuellinator commented 7 years ago

ah, good to know, just wanted to start testing VMs ^^ thanks for your effort - now at least we know...and like i said it's not really a gamebreaker for your awesome addons :D