Quicksaver / The-Fox--Only-Better

A Firefox add-on to improve the feeling of using the new Australis theme.
https://addons.mozilla.org/firefox/addon/the-fox-only-better/
Mozilla Public License 2.0
91 stars 22 forks source link

Mini Location Bar Unresponsive to Status-4-Evar Settings #210

Closed jmain33 closed 7 years ago

jmain33 commented 7 years ago

The mini bar doesn't seem to have awareness of Status-4-Evar's ability to display hovered links, loading progress, page status, etc…

The display of loading progress works OK on the surface, but this is only due to both add-ons being set to display page load progress in the location bar.  I don't believe there is any actual communication happening between the two add-ons in this regard (i.e. Beyond Australis' mini location bar does not explicitly recognize that Status-4-Evar is also displaying the loading progress).  So if Beyond Australis' "view mini bar while pages are loading" setting fails/or is turned off it does not fall back to the fact that S4E is displaying progress there.

Quicksaver commented 7 years ago

It works for the loading indicator for me. For instance if I refresh the page, it shows the mini bar showing the current progress (the minibar normally doesn't appear at all when simply refreshing the page).

Although it's true about the hover links and status at least.

jmain33 commented 7 years ago

Thanks for your effort, I'll see how it goes when the update arrives.

Quicksaver commented 7 years ago

Beta version 1.4.7b1 should show the mini bar when moving the mouse over links (if S4E is set to show the links in the location bar of course). I also made some tweaks so that the mini bar shouldn't hide before the page loading progress indicator is gone (i.e. until it's finished loading).

Please try it out and let me know how it works for you.

jmain33 commented 7 years ago

Links are showing :relieved:, but the mini-bar is using as little horizontal space as possible.  There is an alignment setting in S4E that changes the position of the text (LEFT¦RIGHT¦FIXED); plus a slider for the right and fixed positions that I suppose simply shifts the text's position.  The 2 screenshots below show the output for the same hovered link with an alignment of 100 (Current Location) & of 10 (near the Status Text end). 

------here in the "current location" position------------here in the"status text" position------- 2016-11-17_180207   2016-11-17_180613

The mini-bar is showing much less "links" text than I'd expect and there don't seem to be any settings in S4E which alter the (minimum)length of the text.

My guess would be that Beyond Australis needs to maximize the length of the mini-bar to the length of the text being displayed.  Let me know if I should expect a fix on your end or head on over to the S4E dev.

This will also have an effect on the way loading status text is shown in the mini-bar, when a link is hovered while the loading info is in the bar it will shrink to the size in the screenshots above; and remain that size for an extended period, though it eventually snaps back to the typical length if loading progress takes long enough.

Quicksaver commented 7 years ago

It also has a tiny one-pixel transparency at the bottom, which I hate, I can never figure out why that happens...

I'll look into all this. It definitely should extend to the length of the hovered link at least. But it should not extend over half the width of the window. I can't tell from the screenshots, that's not half of the window right?

jmain33 commented 7 years ago

It also has a tiny one-pixel transparency at the bottom, which I hate, I can never figure out why that happens... :smile:

 

I can't tell from the screenshots, that's not half of the window right?

Those are confusing, guess I shouldn't have cropped it.  The window width is 1080px those caps are only 295px wide.

Quicksaver commented 7 years ago

Alright, the width issue should be fixed in beta version 1.4.7b2. Could you try it out and let me know how it works for you, especially if the tiny background offset that I mentioned is also still happening?

jmain33 commented 7 years ago

Looks Good, I can see the full link now.

Quicksaver commented 7 years ago

It also has a tiny one-pixel transparency at the bottom

What about this, is it still there?

jmain33 commented 7 years ago

Haha 😄, Sure whatever!

It was gone in b2 now it's back in b3

Quicksaver commented 7 years ago

It was gone in b2 now it's back in b3

And the weirdness continues... Do you have Stylish? Can you tell if applying this style helps:

#theFoxOnlyBetter-slimChrome-container[onlyURLBar]:not([hover]) #nav-bar #urlbar-container {
    padding: 2px 0;
}
jmain33 commented 7 years ago

I don't use that particular extension.  I will install it, try that slice of code and let you know how it goes.

Quicksaver commented 7 years ago

There's no need in that case, I made a quick build with that patch. Try beta version 1.4.7b4.

jmain33 commented 7 years ago

Looks entirely good now.  beta4 fixed it.

Quicksaver commented 7 years ago

Awesome! I guess I can finally close this then. :)