search

Quicksaver / The-Fox--Only-Better

A Firefox add-on to improve the feeling of using the new Australis theme.
https://addons.mozilla.org/firefox/addon/the-fox-only-better/
Mozilla Public License 2.0
91 stars 22 forks source link

Completely destroys the UI in Tor Browser (Firefox 45.5.1) #217

Open JaneSmith opened 7 years ago

JaneSmith commented 7 years ago

I tried this add-on with Tor Browser 6.07, which is essentially just a slightly modified version of Firefox 45.5.1. Unfortunately, it completely destroyed the user interface and turned it into a broken, garbled mess. Web pages were completely blank, menus would not pop-up properly - it became completely unusable. I had to forcibly remove the add-on by deleting the .xpi file, as I could not use the Firefox add-ons page.

Riajyuu commented 7 years ago

I believe @Quicksaver has removed all compatibility code with older versions of Firefox, including 45 ESR branches as well. So I'm pretty convinced he not gonna fix this.

JaneSmith commented 7 years ago

I see. That's very disappointing for Tor Browser users, but thanks for the information.

Quicksaver commented 7 years ago

Actually the add-on is fully functional with the latest ESR 45, or it should be at least. :wink: I'll take a look and see what I can find.

Quicksaver commented 7 years ago

Works fine for me. Have you tried disabling all your other add-ons and see if that helps?

JaneSmith commented 7 years ago

Thanks for looking into this. I investigated a bit further, and you're right - it does work with Firefox 45 ESR. However, it doesn't work with Tor Browser, which is based on that same Firefox 45 ESR. Tor Browser comes with four different add-ons out of the box (HTTPS Everywhere, NoScript, Tor Button, and Tor Launcher), but even if I disable all of those default add-ons for testing purposes, this one still completely breaks the UI. I suppose it must just be an incompatibility due to some underlying change they made to the original base code, then?

Quicksaver commented 7 years ago

I did mean that, I tested with a fresh install of Tor Browser.

Quicksaver commented 7 years ago

Have you tried disabling all your other add-ons like I mentioned, not just the default ones?

JaneSmith commented 7 years ago

I don't have any other add-ons installed. Just the default ones; this add-on was the only custom add-on that I was trying. I even downloaded a fresh copy of Tor Browser, with its own fresh profile, and the UI immediately got destroyed as soon as I installed this add-on again. It's very strange that it worked for you and doesn't for me. What could the cause be?

Quicksaver commented 7 years ago

What's your operating system?

JaneSmith commented 7 years ago

I tried it on both Ubuntu 16.10 and Windows 10, and experienced the issue on both.

Quicksaver commented 7 years ago

Disregard what I said in the previous comment, of course it can't do that. I must still have been half-asleep when I thought about that. I'm sorry about that.

Still, I just tried it again and it's working just fine in a fresh install, it's very weird that it isn't working for you. Are either of your Ubuntu or Windows installs fresh installs? Trying in a new profile wouldn't hurt.

Riajyuu commented 7 years ago

I also try it on Tor but it works perfectly for me (Windows 10.14393.479) 20161210_132204