Link Location Bar (Initial title: Bookmarks Toolbar anomaly)

[streetwolf]

See image.

Yes, I can add some spacers to the left and right side to move the cut off icons over but that takes another addon.

I like the way you handle the hiding/restoring. Could you have an option not to have the curves at the ends? Keep it like the default bar?

[Quicksaver]

I already plan to add an option to not add the curves for a future version.

Now, what's that big white space before that percentage number? I have a feeling that's the one causing everything. Also, does that also happen if only TheFOB is enabled?

[Quicksaver]

On the other hand, even with that white space, it seems like the padding that should be in there (just like it is on the nav-bar) is not being applied to the personal toolbar. Could you confirm that this happens also with only TheFOB enabled?

[streetwolf]

This line of css code I use in a Stylish style caused the problem:

PersonalToolbar {padding: 0 4px 1.5px 4px !important;}

The left and right padding are the culprits

From: Luís Miguel [mailto:notifications@github.com] Sent: Tuesday, May 20, 2014 12:30 PM To: Quicksaver/The-Fox--Only-Better Cc: Gary Subject: Re: [The-Fox--Only-Better] Bookmarks Toolbar anomaly. (#33)

On the other hand, even with that white space, it seems like the padding that should be in there (just like it is on the nav-bar) is not being applied to the personal toolbar. Could you confirm that this happens also with only TheFOB enabled?

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/The-Fox--Only-Better/issues/33#issuecomment-43649501 . https://github.com/notifications/beacon/410799__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxNjIyMjYwOCwiZGF0YSI6eyJpZCI6MzI1OTIwNzh9fQ==--343d2e538e0383a46aa863f96bde64b86807e5d6.gif

[Rejlan]

I love the rounded edges, no issues with it on this side. Personally, I wouldn't change the shape for any other.

[Quicksaver]

This line of css code I use in a Stylish style caused the problem: #PersonalToolbar {padding: 0 4px 1.5px 4px !important;}

Yep, you'll have to change that. ;)

[streetwolf]

Btw… I use an add-on called Link Location Bar which allows me to display hovered links in the Location Bar. However, since TFOB doesn’t display the Location Bar when I hover over a link I don’t see the URL. I’m sure there are other add-ons that make use of the Location Bar which must remain visible in order to work properly.

Yes, I can default it to the bottom left of the screen but I really hate that feature.

https://addons.mozilla.org/en-US/firefox/addon/link-location-bar/?src=api

From: Luís Miguel [mailto:notifications@github.com] Sent: Tuesday, May 20, 2014 4:29 PM To: Quicksaver/The-Fox--Only-Better Cc: Gary Subject: Re: [The-Fox--Only-Better] Bookmarks Toolbar anomaly. (#33)

This line of css code I use in a Stylish style caused the problem: #PersonalToolbar {padding: 0 4px 1.5px 4px !important;}

Yep, you'll have to change that. ;)

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/The-Fox--Only-Better/issues/33#issuecomment-43678536 . https://github.com/notifications/beacon/410799__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxNjIzNjk0MiwiZGF0YSI6eyJpZCI6MzI1OTIwNzh9fQ==--895d55be76743817df72714b13d2a0619e4ee831.gif

[Quicksaver]

Btw… I use an add-on called Link Location Bar which allows me to display hovered links in the Location Bar. However, since TFOB doesn’t display the Location Bar when I hover over a link I don’t see the URL. I’m sure there are other add-ons that make use of the Location Bar which must remain visible in order to work properly.

I'll see if I can make it so the toolbars appear when a link is hovered in this case (maybe even show only the mini bar, and instead of showing the current location it would should the destination url only, how does that sound?).

As for other add-ons, I can only add compatibility on a per-case basis. ;)

[streetwolf]

I’ll let you know when you come up with a working version. Send it my way when you got something.

From: Luís Miguel [mailto:notifications@github.com] Sent: Tuesday, May 20, 2014 4:40 PM To: Quicksaver/The-Fox--Only-Better Cc: Gary Subject: Re: [The-Fox--Only-Better] Bookmarks Toolbar anomaly. (#33)

Btw… I use an add-on called Link Location Bar which allows me to display hovered links in the Location Bar. However, since TFOB doesn’t display the Location Bar when I hover over a link I don’t see the URL. I’m sure there are other add-ons that make use of the Location Bar which must remain visible in order to work properly.

I'll see if I can make it so the toolbars appear when a link is hovered in this case (maybe even show only the mini bar, and instead of showing the current location it would should the destination url only, how does that sound?).

As for other add-ons, I can only add compatibility on a per-case basis. ;)

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/The-Fox--Only-Better/issues/33#issuecomment-43679772 . https://github.com/notifications/beacon/410799__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxNjIzNzU5MCwiZGF0YSI6eyJpZCI6MzI1OTIwNzh9fQ==--3cfd6b95c2e1465977807c7c45b966b455bcfb7f.gif

[streetwolf]

Just a thought. How about an option to just hide the bookmarks toolbar, leaving the Location Bar and anything on it as is.

From: Luís Miguel [mailto:notifications@github.com] Sent: Tuesday, May 20, 2014 4:40 PM To: Quicksaver/The-Fox--Only-Better Cc: Gary Subject: Re: [The-Fox--Only-Better] Bookmarks Toolbar anomaly. (#33)

Btw… I use an add-on called Link Location Bar which allows me to display hovered links in the Location Bar. However, since TFOB doesn’t display the Location Bar when I hover over a link I don’t see the URL. I’m sure there are other add-ons that make use of the Location Bar which must remain visible in order to work properly.

I'll see if I can make it so the toolbars appear when a link is hovered in this case (maybe even show only the mini bar, and instead of showing the current location it would should the destination url only, how does that sound?).

As for other add-ons, I can only add compatibility on a per-case basis. ;)

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/The-Fox--Only-Better/issues/33#issuecomment-43679772 . https://github.com/notifications/beacon/410799__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxNjIzNzU5MCwiZGF0YSI6eyJpZCI6MzI1OTIwNzh9fQ==--3cfd6b95c2e1465977807c7c45b966b455bcfb7f.gif

[Quicksaver]

Already in the to-do list. #31 ;)

[streetwolf]

Cool.

Btw… I opened up a problem report with FBT v2b1

From: Luís Miguel [mailto:notifications@github.com] Sent: Tuesday, May 20, 2014 4:50 PM To: Quicksaver/The-Fox--Only-Better Cc: Gary Subject: Re: [The-Fox--Only-Better] Bookmarks Toolbar anomaly. (#33)

Already in the to-do list. #31 https://github.com/Quicksaver/The-Fox--Only-Better/issues/31 ;)

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/The-Fox--Only-Better/issues/33#issuecomment-43681000 . https://github.com/notifications/beacon/410799__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxNjIzODE5MCwiZGF0YSI6eyJpZCI6MzI1OTIwNzh9fQ==--598d46a91ddc49d19598c9a526baf2e987f3287b.gif

[Quicksaver]

Reopening so I don't forget.

[Quicksaver]

Just uploaded a beta with a compatibility fix for Link Location Bar. Now hovering a link will show it in the mini bar (only if the toolbar isn't visible already of course). Give it a try (https://addons.mozilla.org/en-US/firefox/addon/the-fox-only-better/versions/) and let me know what you think.

[streetwolf]

Gave it a try and can’t decide if I like it or not. The regular location is only shown if I hover over a bookmark on my toolbar since the toolbars are unhidden at the time. The sidebar bookmark and content links have your box. Btw, your box covers the icons I have placed on the OmniSidebar toolbar.

Personally the way I would like to use THOB is to only autohide my bookmarks toolbar. Doing so would allow me to use the URL box for my hovered links. Since THOB is a WIP perhaps this will be an option.

btw.. I notice the toolbars don’t either hide or unhide cleanly. They seem to shift to the left for a second. I would expect them to appear disappear instantly unless you put some sort of fade in capability.

From: Luís Miguel [mailto:notifications@github.com] Sent: Sunday, June 1, 2014 7:06 AM To: Quicksaver/The-Fox--Only-Better Cc: Gary Subject: Re: [The-Fox--Only-Better] Link Location Bar (Initial title: Bookmarks Toolbar anomaly) (#33)

Just uploaded a beta with a compatibility fix for Link Location Bar. Now hovering a link will show it in the mini bar (only if the toolbar isn't visible already of course). Give it a try (https://addons.mozilla.org/en-US/firefox/addon/the-fox-only-better/versions/) and let me know what you think.

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/The-Fox--Only-Better/issues/33#issuecomment-44774959 . https://github.com/notifications/beacon/410799__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxNzIzOTk1NCwiZGF0YSI6eyJpZCI6MzI1OTIwNzh9fQ==--0f981de03db9201b24379467abe15d0e80ff0cc1.gif

[Quicksaver]

The regular location is only shown if I hover over a bookmark on my toolbar since the toolbars are unhidden at the time. The sidebar bookmark and content links have your box.

This is expected, there's no point in showing the whole chrome just to show the link (IMO), it only shows the mini bar, but in this case the mini bar will extend as much as possible to show the full link.

Btw, your box covers the icons I have placed on the OmniSidebar toolbar.

Also expected if the sidebar is not docked, it doesn't actually take up content space, so the toolbars appear above it.

Personally the way I would like to use THOB is to only autohide my bookmarks toolbar. Doing so would allow me to use the URL box for my hovered links. Since THOB is a WIP perhaps this will be an option.

I agree that for your case this will probably be the best option. This will come soon. ;)

btw.. I notice the toolbars don’t either hide or unhide cleanly. They seem to shift to the left for a second. I would expect them to appear disappear instantly unless you put some sort of fade in capability.

Yeah you're right, I keep forgetting to fix that. Just fixed it locally quickly so I don't forget.

[Quicksaver]

There's not much else I can do on this front, so I'm closing this issue. You might want to follow #33 for the rest.

[Quicksaver]

Of course, I meant you might want to follow #31 (#33 is this one), where I just posted about the latest beta which has this feature. :)