Quicksaver / The-Fox--Only-Better

A Firefox add-on to improve the feeling of using the new Australis theme.
https://addons.mozilla.org/firefox/addon/the-fox-only-better/
Mozilla Public License 2.0
91 stars 22 forks source link

Toolbars failing to disappear completely #9

Closed puppable closed 8 years ago

puppable commented 10 years ago

When mousing away, the toolbars will occasionally cease the closing animation abruptly, frozen in a semitransparent, shrunken state. Mousing on and off of the top bar once more will usually clear them away. This issue most frequently occurs when the browser is suffering significant lagging.

Quicksaver commented 10 years ago

That's unfortunate. The only thing I can think of that might be causing this (and has a proper fix) could be another add-on interfering. You could try and disable all your other add-ons and see if this still happens like that. Also to be safe, open the browser console (Ctrl+Shift+J), clear it, and when the toolbars get frozen, see if any messages or errors appear in it (if you're in doubt if the messages are relevant, just copy everything here and I'll take a look).

However, if it truly is an issue with the browser lagging because it's just too much processing for it to do, then the only way is to go at the root of the problem: remove any add-ons you don't use, or even start over with a new profile in case it's some leftovers from previous add-ons or any corruption that might have happened and could worsen your browser responsiveness.

Unfortunately, the add-on doesn't actually do any of the animations, so it can't "control" them. For the add-on, there is only a "shown" and "hidden" state for the toolbars (for the opacity this is literally a "1" and "0"). The add-on only tells the browser to "animate this change, so it happens over x.x seconds", and firefox's rendering engine takes care of the rest.

I've already made these transitions as simple and as fast as possible, to make them smooth and so they don't interfere with browser responsiveness. Perhaps there is still some room for improvement, and I can look into it, but I seriously doubt it will help much in your situation. If it's not a specific add-on interfering, there really is so much the browser can do, and that varies from system to system.

puppable commented 10 years ago

I see. This is probably an issue with my browser, then. I have had similar issues with the status bar fading out, and it doesn't seem to be caused by an addon. Thanks!

Quicksaver commented 10 years ago

Please let me know if/how you resolve this, for example if after creating a new profile with only TheFOB the issue still happens or if it's fixed. In case there is something I can do I will of course.

Quicksaver commented 10 years ago

Are you still having this issue with the latest version 1.0.7?

Mte90 commented 10 years ago

I can confirm this problem but with the 1.0.8b2 the problem happens less than before.

Quicksaver commented 10 years ago

Could you take a print screen of this when this happens please? And if you can give me exact steps to reproduce would be great, as in exact steps that when you follow them you're sure that the toolbars won't hide completely.

Mte90 commented 10 years ago

i think that happen when i'm switching very fast from a tab to another and the mouse hover the address bar showed. http://imgur.com/euj2BFF

Quicksaver commented 10 years ago

Ok, I have to give you guys a little homework, I'm sorry in advance for the trouble.

The next time this happens make sure you don't hover the toolbars so it doesn't fix itself, and open the browser console (Ctrl+Shift+J) and paste the following command in (it's only one command, make sure you paste everything), and tell me the return value.

theFoxOnlyBetter.slimChromeContainer.hasAttribute('hover')+' '+theFoxOnlyBetter.slimChromeContainer.hasAttribute('mini')+' '+theFoxOnlyBetter.slimChromeContainer.hasAttribute('noPointerEvents')+' '+getComputedStyle(theFoxOnlyBetter.slimChromeContainer).getPropertyValue('opacity');

If your browser console doesn't have the input field at the bottom, you'll have to enable it beforehand. Just hit Ctrl+Shift+K to open the web console at the bottom of the main browser window, open the toolbox options (top left) and enable the checkboxes that say "Enable chrome and addon debugging" and "Enable remote debugging" (you can close the webconsole in the main browser window now). After this, when you open the browser console it will have the input field at the bottom where you should enter those commands.

Woowoo678, if you can do this too with the latest beta version (https://addons.mozilla.org/firefox/addon/the-fox-only-better/versions/) I would really appreciate it, to confirm that the issue has the same underlying cause for both.

stmr commented 10 years ago

I can also confirm this bug, the code you posted above shows me this: ReferenceError: theFoxOnlyBetter is not defined so I'm probably doing something wrong (both options mentioned in your post enabled, using latest beta version).

I'm not that optimistic about solution though, cause it seems to me that this is FF related bug, because the pop-up that shows up when you hover url does exactly the same thing.

Quicksaver commented 10 years ago

You're inputting that code in the standalone window that opens when you hit Ctrl+Shift+J right (browser console)? It's NOT the bottom console that appears when you hit Ctrl+Shift+K (web console). If you are inputting in the browser console... well that's just wrong, there's no way that theFoxOnlyBetter is undefined while the add-on is still running. O.O Can you please confirm this?

stmr commented 10 years ago

My bad, of course I've used wrong console. Here's the output: "false false true 0" The result is as it should be, as I've written before, this is probably FF bug, since it happens even with url popup. I've also noticed, that making navbar show and hide again doesn't fix the visual bug, not even changing to another tab and returning back. It also seems more likely to get bugged when you already have it bugged on another tab. This all goes for both FOB and url popup.

Quicksaver commented 10 years ago

the pop-up that shows up when you hover url does exactly the same thing.

What exactly do you mean by this? Could you get a screenshot of this when it happens next please?

puppable commented 10 years ago

stmr is referring to the URL that shows in the bottom-left (or right) when hovering a link in Firefox. I can confirm that the same thing happens to me in its fade out animation (when the link is moused away from). This is almost certainly an issue with how Firefox renders fade out animations.

Aside from that, I've installed the most recent beta version of TFOB and will get the reading when I can.

stmr commented 10 years ago

Exactly as Woowoo678 says. Here's reading with last beta: "false false true 0" which is the same as with previous beta and it's how it should be.

UPDATE: Here's part of screen with same visual bug with that bottom-left/right URL: http://s5.postimg.org/gc0xrltmf/urlpop.png (bottom grey line is main windows bar, fragments on right are parts of facebook posts).

Quicksaver commented 10 years ago

That does seem like an issue with the browser yeah. Does this only happen with TheFOB enabled? Or if you disable the add-on, the link text will sometimes also fail to disappear completely?

stmr commented 10 years ago

It happens even with TheFOB disabled

Quicksaver commented 10 years ago

It could be another add-on interfering with firefox somehow. Does it happen when all add-ons are disabled and you're using the default theme? (Yeah, this no longer seems to be an issue with TheFOB, but I'm curious now to know what's causing this, as I've never seen it before. If that happens without any other add-on or theme enabled, it's kind of a serious issue.) Exactly what operating system are you on by the way?

Quicksaver commented 10 years ago

Also, you could try opening firefox's options, "advanced" pane, "general" tab and toggle "Enable hardware acceleration when available" (if it's disabled, enable it and vice versa), it could help, it could not. It's the only thing native to firefox that I can remember right now that could influence this.

stmr commented 10 years ago

I'm using latest Nightly on Windows 7 HP 64 bit, hardware acceleration doesn't affect this, but so far it seems that disabling pdf.js solves this. It's strange, I'm running with pdf.js disabled and if the bug shows up again, I'll let you know. Update: It's happening again, so this wasn't the issue. Latest version of TheFOB ofc

Quicksaver commented 10 years ago

How are you disabling this? I didn't even know that could be done.

Quicksaver commented 10 years ago

I was going to ask if you meant you were disabling the add-on PDF.JS or the internal pdf viewer, but nevermind then if that has nothing to do with it. Have you tried disabling everything? As in, does this happen in a clean profile? If it does, you might want to open a bug in bugzilla for this.

stmr commented 10 years ago

about:config -> pdfjs.disabled set to true.

I'm running separate clean profile where I haven't encountered this yet, but I'm not using it as much, because it's uncomfortable without addons. I've tried to disable everything and it looked fine, everything worked fine until enabling PDF.js addon and stylish, I suspect one of those (but it could be anything else, since I don't know what to do to reproduce the bug, it occurs randomly)

Quicksaver commented 10 years ago

It shouldn't be either PDF.JS (as it comes enabled by default in firefox and I'm sure someone else might have seen it before) or stylish. I frequently use both in both Nightly and Release Firefox and I've never seen this. It could be a custom stylish script you have...

Quicksaver commented 10 years ago

There were some changes introduced in firefox 34 (current nightly) that may help with this issue. If anyone is currently using Nightly already, have you seen this issue lately?

If you would like to try Nightly out to see if it helps with this issue it's easy, you can install it alongside your regular firefox installation and even use the same profile (although you can also use a new one if you want, just ask and I'll tell you how). Just go to https://nightly.mozilla.org/, download and install it and see if the issue still occurs there.

Aralun commented 10 years ago

Had this issue, disappeared completely a couple Firefox versions.

Quicksaver commented 10 years ago

They have been rolling out some improvements to the rendering engine in firefox, especially in firefox 34 I believe. @Woowoo678, @Mte90, @stmr, do any of you still experience this?

damien-rivet commented 9 years ago

Having the same problem with FF 34.0 (Release) :

tfob_issue_9

Dunno if it can help or not.

Quicksaver commented 9 years ago

Does this also happen for the link status text (on the bottom corner, when you mouse over a link), like stmr mentions above?

damien-rivet commented 9 years ago

Nope, status bar link fades normally even when TFOB is translucent.

orschiro commented 9 years ago

Can confirm the issue with version 1.1.8 and Firefox 34.0.5 and will try to find out which add-on might be interfering. Using some custom stiles with User Style Manager.

screenshot

orschiro commented 9 years ago

Disabled User Style Manager for a while now. Issue did not appear again. Can someone using User Style Manager can confirm that it is causing a compatibility problem?

Quicksaver commented 9 years ago

It may not be User Style Manager (USM) itself, but maybe one of the styles you have enabled. If you disable all its styles, but keep USM enabled, does the issue happen?

orschiro commented 9 years ago

It may not be User Style Manager (USM) itself, but maybe one of the styles you have enabled. If you disable all its styles, but keep USM enabled, does the issue happen?

Yes it does. Makes it more difficult to find the incompatibility.

On 10.01.2015 12:37, Luís Miguel wrote:

It may not be User Style Manager (USM) itself, but maybe one of the styles you have enabled. If you disable all its styles, but keep USM enabled, does the issue happen?

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/The-Fox--Only-Better/issues/9#issuecomment-69452870.

Sharing my passion & inspiration for

sustasty lifestyles #transitions

opensource #degrowth / Love

bouldering

Flying is old-school and the world cannot be saved part-time

Co-Creator of @MindfulMeerkats

www.robert.orzanna.de twitter.com/@orschiro

orschiro commented 9 years ago

Correction: it was related to one of my stylesheet which assigned favicons to bookmarklets. On Jan 10, 2015 12:39 PM, "Robert Orzanna" orschiro@gmail.com wrote:

It may not be User Style Manager (USM) itself, but maybe one of the styles you have enabled. If you disable all its styles, but keep USM enabled, does the issue happen?

Yes it does. Makes it more difficult to find the incompatibility.

On 10.01.2015 12:37, Luís Miguel wrote:

It may not be User Style Manager (USM) itself, but maybe one of the styles you have enabled. If you disable all its styles, but keep USM enabled, does the issue happen?

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/The-Fox--Only-Better/issues/9#issuecomment-69452870 .

Sharing my passion & inspiration for

sustasty lifestyles #transitions

opensource #degrowth / Love

bouldering

Flying is old-school and the world cannot be saved part-time

Co-Creator of @MindfulMeerkats www.robert.orzanna.detwitter.com/@orschiro

Quicksaver commented 9 years ago

Could you link me to that stylesheet? Or maybe post it here please? I'd like to give it a try and see if I can also reproduce the issue.

orschiro commented 9 years ago

Sure. Thanks for looking into it:

|@namespace url(http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul); /* Welcome to the Style Editor window of User Style Manager. */

/* Add favicons to bookmarkets http://forums.mozillazine.org/viewtopic.php?f=7&t=1755885 */

toolbarbutton[class="bookmark-item"][label="Bitlink"] { list-style-image: url("https://d1ayxb9ooonjts.cloudfront.net/22f1d0b2154c2f58baf06f92038d262a.png") !important; }

toolbarbutton[class="bookmark-item"][label="Add event"] { list-style-image: url("https://calendar.google.com/googlecalendar/images/favicon_v2014_4.ico") !important; }

toolbarbutton[class="bookmark-item"][label="UU Proxy"] { list-style-image: url("http://www.google.com/s2/favicons?domain=www.uu.nl") !important; }

toolbarbutton[class="bookmark-item"][label="jetzt"] { list-style-image: url("https://github.com/ds300/jetzt/raw/master/img/screenshot.png") !important; }

toolbarbutton[class="bookmark-item"][label="Squirt"] { list-style-image: url("http://www.squirt.io/images/logo.png") !important; }

toolbarbutton[class="bookmark-item"][label="Word Count"] { list-style-image: url("https://addons.cdn.mozilla.net/user-media/addon_icons/4/4718-64.png?modified=1281079852") !important; }

toolbarbutton[class="bookmark-item"][label="Save to Zotero"] { list-style-image: url("http://www.google.com/s2/favicons?domain=www.zotero.org") !important; }

toolbarbutton[class="bookmark-item"][label="Save to blogtrottr"] { list-style-image: url("http://www.google.com/s2/favicons?domain=www.blogtrottr.com") !important; }

toolbarbutton[class="bookmark-item"][label="Save to Mendeley"] { list-style-image: url("http://www.mendeley.com/favicon.ico") !important; } |

On 01/24/2015 02:51 PM, Luís Miguel wrote:

Could you link me to that stylesheet? Or maybe post it here please? I'd like to give it a try and see if I can also reproduce the issue.

— Reply to this email directly or view it on GitHub https://github.com/Quicksaver/The-Fox--Only-Better/issues/9#issuecomment-71317512.

Sharing my passion & inspiration for

sustasty lifestyles #transitions

opensource #degrowth / Love

bouldering

Flying is old-school and the world cannot be saved part-time

Co-Creator of @MindfulMeerkats

www.robert.orzanna.de twitter.com/@orschiro

Quicksaver commented 9 years ago

So I've been using that style with User Style Manager for a little while, and surfing around the web and moving the mouse over and out of the toolbars like crazy. So far, nothing...

I've decided to report this to mozilla bug 1125606 since I am just about out of ideas, and I realize this is a big nuisance for you guys... Let's see if they're able to shed any light in the matter. In the meantime, if anyone thinks of anything else that might be relevant to the issue, please post here or on that bug.

I'm very sorry I'm not able to give you all a more prompt solution.

Quicksaver commented 9 years ago

BTW, I don't see anything in that userstyle that could even come close to interfering with the toolbars opacity, it's just icons after all... If there is something related to it, it's a bug buried deep in firefox's rendering engine.

orschiro commented 9 years ago

I keep experimenting and now it seems to work for some reasons. However, I encounter another issue with the add-on not nicely integrating into my setup:

image

Please note the white bar and the half-shown skylights icon.

The custom style I am using is the following:

@namespace url(http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul);

toolbar {
    background: #DEDEDE !important;
}

#TabsToolbar:not([collapsed="true"]) + #nav-bar {
   border-top: none !important;
}

Could you give me some final advice on how to make the add-on integrate more nicely?

Thanks!

Robert

Quicksaver commented 9 years ago

@orschiro try giving a once over to issue #24, it has instructions for how to apply themes to the add-on. In your case, I suggest not styling the toolbars individually like that, but apply any styling you need like suggested in that issue. Please let me know (in that thread) if you need any more specifics and I'll be happy to help. :)

Quicksaver commented 9 years ago

Just as an update, has any of you experienced this issue in the most recent versions of firefox?

orschiro commented 9 years ago

@Quicksaver

I cannot report back anymore since I switched from Firefox to Chromium. Sorry!

Aralun commented 9 years ago

Could not reproduce on Firefox 40.0a2 (Dev Edition). This reminded me to put it back on! Having space feels good.