Quicr / hactar

Hardware design for test device
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

Serial Packet Manager doesn't filter sent packets correctly #95

Closed BrettRegnier closed 6 months ago

BrettRegnier commented 6 months ago

Expected behaviour: When a packet is sent by the serial manager it checks the packet type:

  1. If the packet type is a OK, Error, Busy, or LocalDebug type it will delete the packet and move on.
  2. Otherwise push it onto a pending packets map and wait for a OK, Error, or Busy packet to confirm it or perform re-transmission.

Actual behaviour: When a packet is send by the serial manager, all packets are pushed onto the pending packets map, and since no Ok, Error, or Busy is sent for the aformentioned types they will stay on the map forever, until it has been re-sent 3 times and then finally deleted.

BrettRegnier commented 6 months ago

Fixed on this commit