Quicr / numero-uri

BSD 2-Clause "Simplified" License
1 stars 0 forks source link

Refactor library a bit #6

Closed fluffy closed 1 year ago

fluffy commented 1 year ago

I think all the stuff for managing configuration should be outside the library and the library works on the assumption that a valid JSON file is loaded into memory then passed into the library. So the CLI program might still have stuff for accessing a file but it all moves out to that.

BrettRegnier commented 1 year ago

I believe the configuration is outside of the library itself, but adding and removing templates with the URLTemplater would still need access to a file otherwise it will not have anyway to get the templates into memory right?

BrettRegnier commented 1 year ago

Now that I am rethinking this, I was way off point with what I was talking about, since its not going to be a api that is called, but rather a library that is integrated by another developer. I will make this change.

BrettRegnier commented 1 year ago

Fixed with this commit