QuiiBz / sherif

Opinionated, zero-config linter for JavaScript monorepos
MIT License
898 stars 13 forks source link

"Failed to collect package" results in clean exit with "No issues found" #103

Closed bitttttten closed 3 hours ago

bitttttten commented 4 hours ago

If we run sherif on our monorepo we see:

$ npx sherif
 ⨯ error Failed to collect package
   Error while parsing "./packages/c/package.json": invalid type: string "true", expected a boolean at line 4 column 19

✓ No issues found

Although on circleci this passes with a green ✅ , i.e. npx sherif && echo 'hello' will echo hello. Should it be that this error should also fail the linter and exit?

bitttttten commented 4 hours ago

The problem with our package.json was that we had "private": "true", instead of "private": true,.

QuiiBz commented 3 hours ago

Thanks for the report, that happens when we fail to parse a package.json. I released version 1.0.2 that includes https://github.com/QuiiBz/sherif/pull/104