QuiiBz / sherif

Opinionated, zero-config linter for JavaScript monorepos
MIT License
912 stars 14 forks source link

Wish option to view 'multiple-dependency-versions' as a warning instead of an error. #46

Closed sungh0lim closed 11 months ago

sungh0lim commented 11 months ago

I want to include Sherif in CI, but it's difficult to match versions right away in the project we are transferring. So, I wish there was an option to change items that appear as errors to warnings.

QuiiBz commented 11 months ago

Sherif is very opinionated and we don't really want to add a configuration step, even if not mandatory.

While you're updating your dependencies, you can use the --ignore-rule multiple-dependency-versions option to ignore entirely the rule, or --ignore-dependency @dependency/name to ignore a specific dependency. That should help integrating Sherif in your CI immediately, and enable the rule later when you've fixed all dependencies errors.

Let me know if that would work for you.

sungh0lim commented 11 months ago

Rather than ignoring it, I just wanted it to be checked every time in CI with warning option. Thanks for the reply. We decided to use this for monthly checking rather than putting it in CI.

QuiiBz commented 11 months ago

Thanks, I'll close the issue unless more folks are interested in the same feature.