search

QuiiBz / sherif

Opinionated, zero-config linter for JavaScript monorepos
MIT License
673 stars 10 forks source link

Incompatible dev and peer dependencies not detected #63

Open steida opened 3 months ago

steida commented 3 months ago

Check @sqlite.org/sqlite-wasm. I forget to add caret, and it wasn't detected. Thank you for the fantastic checker.

"devDependencies": {
    "@evolu/common": "workspace:*",
    "@evolu/tsconfig": "workspace:*",
    "@sqlite.org/sqlite-wasm": "3.45.3-build2",
    "@types/web-locks-api": "^0.0.5",
    "eslint": "^8.57.0",
    "eslint-config-evolu": "workspace:*",
    "typescript": "^5.4.5",
    "user-agent-data-types": "^0.4.2",
    "vitest": "^1.6.0"
  },
  "peerDependencies": {
    "@evolu/common": "^5.1.2",
    "@sqlite.org/sqlite-wasm": "3.45.1-build2"
  },

https://github.com/evoluhq/evolu/issues/405

QuiiBz commented 3 months ago

That might be hard to do. We removed the explicit versions check because of https://github.com/QuiiBz/sherif/issues/61, but checking if the dependencies satisfy the peer dependencies correctly would be great.