search

QuilibriumNetwork / ceremonyclient

Mirror of Quilibrium git repo: ceremonyclient
GNU Affero General Public License v3.0
95 stars 41 forks source link

bandwidth test: pause between retries #136

Closed shyba closed 8 months ago

shyba commented 8 months ago

Most of the peers that lack a bandwidth test are new to pubSub, specially during start up, so they lack a multiaddr at this point.

The current code keeps retrying them without a pause, which showed up on profiler due high CPU usage.

The following change adds a random pause to make those missing an address wait before retry, although I'm not sure for how long they should be retried (I can open a follow up PR that handles pending peers better, if that is useful)

CassOnMars commented 8 months ago

Nice catch! Randomness is a bit of a tough call – it would work better for CPU compared to current case, but it's still possible some peers may never pan out (misbehavior), or may take a little longer if the mesh is going through heavy thrashing between updates. I'm going to hook it into the address stream from libp2p and make it wait on a viable address so no re-attempts/randomness is required and just fail it out after some time, where subsequent announcements will make it through. Will get it rolled into 1.4.11. 🙏🏻

shyba commented 8 months ago

Closing as it will be handled in 1.4.11

Thank you!