lilyosah commented 2 years ago

Changes

❗Breaking change: use id instead of pk for Task model

I changed the tasks database to use id instead of pk so that we can use uuids instead of integers. This made it easier to "create" a task in the MobX task store by generating a new uuid in the FE and passing it to the back-end to be actually created.

To update your DB: After pulling from main after this is merged, all of the old migrations are deleted.

Delete all of the files in ./tasks/migrations/pycache/ and ./tasks/pycache

Drop old database

psql postgres

In psql:

DROP DATABASE IF EXISTS quill_db;

or

DROP DATABASE quill_db;

Run scripts to init DB as seen in contributing > Setting up the development environment > Back-End > 7. Init back-end using npm scripts

Added task creation pop-up

It has some basic validations in the FE and a time-picker for the times, not for the date. This was my reasoning:

Design question: I was always conflicted about the date/time picker we had in task creation since it just seems like a mini version of the calendar we already have. How would people feel about this idea?

Clicking create task button opens the creation pop-up

In the title field they can type just the title or other data that will be parsed for the other fields. So they could type "Do HW" and that would be the title and nothing else, or the could type "do hw this friday" and after they finished typing the due date field would be automatically populated with the date for that Fri, or maybe just "this friday" but it would be converted to the timestamp behind the scenes

Clicking on the start and due fields, the field is highlighted.

you can type a date in a parseable format like 1/18/2022 or type in natural language like "this friday".

If after clicking on that field if you click on a date in the calendar (pop-up stays open and functional, that field stays highlighted) that date is populated in the field in the pop-up. If they select from the day view in the calendar (the vertical timeline) then the time they clicked is automatically populated too. Otherwise, there is a time-picker (no date picker tho) next to the field do easily select a time if they want one.

Detail for init scripts

Added more detail about getting database up and running and separate scripts for Windows and Mac. Hopefully they work for everyone. There are details about them in contributing.md

Codecov

Set up a workflow to run coverage reports and upload them to codecov so we can get the shiny badge on our readme!

About the tests and coverage

The coverage for this commit is not great because I ran into issues with every test that used Testing Library for keyboard input. I want to get these changes merged and then I'm going to create a coding sandbox and submit a bug report with them, I've updated the issue involving it. #63

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@6e17adf). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head 47010b4 differs from pull request most recent head f1f104c. Consider uploading reports for the commit f1f104c to get more accurate results

@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage        ?   76.02%           
=======================================
  Files           ?       15           
  Lines           ?      559           
  Branches        ?      123           
=======================================
  Hits            ?      425           
  Misses          ?      134           
  Partials        ?        0

Flag	Coverage Δ
FE	`76.02% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e17adf...f1f104c. Read the comment docs.