search

Quillraven / Fleks

Fast, lightweight, multi-platform entity component system in Kotlin
MIT License
180 stars 20 forks source link

Adjust auto-publishing workflow #108

Closed aSemy closed 1 year ago

aSemy commented 1 year ago

Adjust the 'publish' workflow so that it's called by the 'build' workflow as a reusable workflow

This hopefully fixes the issue described in #106

@aSemy : any idea why "Publish" workflow gets triggered for PRs? I thought the if condition in the job should prevent that? Obviously, I am wrong :D

Originally posted by @Quillraven in https://github.com/Quillraven/Fleks/issues/106#issuecomment-1637548926

I'm not 100% certain that this will solve the issue, so please double check it!

aSemy commented 1 year ago

Seems to work as expected for pull requests, so the publish workflow is skipped

image

Hopefully the publish workflow will be triggered correctly when 'build' runs on the master branch!

aSemy commented 1 year ago

I see that the 'publish' workflow is still triggered: https://github.com/Quillraven/Fleks/actions/runs/5574312973/workflow

This is because GitHub is still picking up the unmodified publish.workflow that's on the master branch. The at 1336150 links to the master branch version: https://github.com/Quillraven/Fleks/commit/1336150553e685db69ac2b7b35057f245a566ed6

image

I expect that the publish workflow will no longer be triggered when the 'build' workflow completes if this PR is merged is merged in.