search

QuiltMC / enigma

A deobfuscation/remapping tool for Java bytecode, fork of cuchaz's Enigma.
GNU Lesser General Public License v3.0
59 stars 31 forks source link

update default dark theme colors #214

Closed supersaiyansubtlety closed 3 months ago

supersaiyansubtlety commented 4 months ago

Now with darker darks and lighter lights:

Before/after 1 ![enigma-default-dark-theme-before-after-1](https://github.com/user-attachments/assets/9cd24784-cc8e-4e75-8448-bd99d11ffe22)
Before/after 2 ![enigma-default-dark-theme-before-after-2](https://github.com/user-attachments/assets/6fdb8f5e-1d42-486d-844c-936e9521911d)
supersaiyansubtlety commented 4 months ago

Bonus:

ix0rai commented 3 months ago

i'll be honestly i personally like the old one better i think the contrast between the code view and the rest of the window is a bit much would you mind moving this into its own theme?

supersaiyansubtlety commented 3 months ago

It would look better if the dark LaF was darker... (I'd like to make that customizable in another PR, eventually)

I could move it to another theme, but it'd require reworking how default syntaxpane colors are loaded, currently they only allow for one dark and one light set of default colors.

Before I do that I'd like to hear what @OroArmor and @woodiertexas think of this theme. No need to ship it with Enigma if I'll be the only one using it.

ix0rai commented 3 months ago

i've been meaning to do a proper customisation screen in swing for ages

OroArmor commented 3 months ago

Before I do that I'd like to hear what @OroArmor and @ woodiertexas think of this theme. No need to ship it with Enigma if I'll be the only one using it.

Hm I agree with rai that I don't really like the darkness of the code compared to the sidebars. If those were darker I think I would like it more

woodiertexas commented 3 months ago

personally, the enigma UI should be as dark as the code view

supersaiyansubtlety commented 3 months ago

Alright, sounds like we all agree it would be better if the non-syntaxpane colors (LaF colors) where also darker.

Closing this in favor of https://github.com/supersaiyansubtlety/enigma/tree/improve-theme-handling.

I aim to implement LaF color customization there. I'll open a draft PR once the ClassCastException I asked about on discord is sorted out.