QuiltMC / enigma

A deobfuscation/remapping tool for Java bytecode, fork of cuchaz's Enigma.
GNU Lesser General Public License v3.0
57 stars 31 forks source link

Adding javadoc to method override param is allowed but flawed #225

Closed supersaiyansubtlety closed 1 month ago

supersaiyansubtlety commented 1 month ago

Working on a QMap PR based on https://github.com/QuiltMC/quilt-mappings/commit/5f958526ccfcb3e3b8c9a3d31ea31fdcbd2ce487

I can edit the javadoc of the param of net.minecraft.world.tick.ChunkTickScheduler#getAllTicks (m_khwqakbu), which is an override of net.minecraft.world.tick.SerializableTickScheduler#getAllTicks.

In the editor it looks like this, with null for the param name: java_HH9q6JG04r

The mapping file looks like this:

METHOD m_khwqakbu (J)Ljava/util/List;
    ARG 1
        COMMENT used to convert from {@link net.minecraft.world.tick.OrderedTick#triggerTick() OrderedTick.triggerTick}
        COMMENT to {@link net.minecraft.world.tick.Tick#delay() Tick.delay}

And in fakeSource it looks like this:

   /**
    * Mapping not found
    */
   @Override
   public List<Tick<T>> getAllTicks(long time) {

Adding the comment to the base method's param works fine.

ix0rai commented 1 month ago

can confirm. will create a test for this and get it fixed!