search

QuiltMC / quilt-config

Quilt Config (aka "haven king's metadata of madness") is a library designed to facilitate the creation and management of config files.
Apache License 2.0
21 stars 8 forks source link

Using identifiers as the keys of ValueMaps with TOML #23

Closed sisby-folk closed 8 months ago

sisby-folk commented 8 months ago

Hey there! there's an issue with toml serialization detailed here that I want to inquire about.

We have a <String,String> valuemap where each side are stringified arbitrary Identifiers.

Identifiers can legally include . in their paths, which means that the string keys may include . - these are arbitrary additions into the config by the user, we do not know what block or item IDs will be used and whether they will include ..

This of course means that on latest it's garbled into nonsense like so: image

Is there any way for this to work and not totally fail serialization in TOMLSerializer? or should we switch to JSON5?

sisby-folk commented 8 months ago

ah hold on, this issue might be invalid - I think our dependencies didn't refresh when updating to latest.

image

sisby-folk commented 8 months ago

Yep, no problems now, oops - great job on the new changes btw! :P

image