search

QuiltMC / quilt-loader

The loader for Quilt mods.
Apache License 2.0
472 stars 87 forks source link

match QM conventions in api methods #361

Closed ix0rai closed 1 year ago

ix0rai commented 1 year ago

ModContainer#metadata and ModContainer#rootPath in org.quiltmc.loader.api.ModContainer violate the QM convention of always prefacing getters with get unless they're part of a record. this should be fixed to ensure all quilt tooling has a consistent naming scheme!

AlexIIL commented 1 year ago

ModMetadata, Version, ModLicense, ModContributor, ModDependency, ProvidedMod, LoaderValue also all violate this convention. But since we don't have plugins yet we can break them (and add default methods for backwards compat) so it's definitely possible for us to change this.

OroArmor commented 1 year ago

Personally im not a huge fan of .get and I think more modern APIs, like loader, can go without.

TheGlitch76 commented 1 year ago

For context, Loader uses this naming convention because Java is explicitly going that way with records and pretty much all new APIs.

ix0rai commented 1 year ago

sounds good then!