QuiltMC / quilt-loader

The loader for Quilt mods.
Apache License 2.0
472 stars 87 forks source link

Add path retention to the plugin manager. #385

Closed AlexIIL closed 9 months ago

AlexIIL commented 11 months ago

This allows plugins to scan from mods that were originally scanned before the plugin was loaded.

The main API addition is QuiltLoaderPlugin.isHigherPriorityThan, which is intended to allow plugin developers to co-operate on whether their plugin should take priority over mods loaded by another plugin, from the same original file.

This also adds a new table:

5 unknown / unsupported mod files found:
| Size (Bytes) | Type                | Path                                         |
|-------------:|---------------------|----------------------------------------------|
|       58,696 | risugamis_modloader | <mods>/buildcraft-1.4.1.zip                  |
|    3,477,068 | forge               | <mods>/buildcraft-7.2.8.jar                  |
|    7,137,846 | forge               | <mods>/journeymap-1.20.1-5.9.18-forge.jar    |
|    7,070,082 | neoforge            | <mods>/journeymap-1.20.2-5.9.18-neoforge.jar |
|          102 | unknown             | <mods>/random file.java                      |
|-------------:|---------------------|----------------------------------------------|

It's probably better to display these in a full warning message, but for now they appear in the Mod Loading State screen: Screenshot from 2023-11-23 09-08-34 Note: that has been replaced by a new screen: image

This also includes a better error message for zero-byte files (when named .zip or .jar): Screenshot from 2023-11-23 08-24-52

AlexIIL commented 11 months ago

I've updated this to include a proper error message with the types of unknown mods.

This also includes a link to your RGML-Quilt project, but I'm not sure if you'd want this to be added yet? (Maybe when loader plugins are stable). image