search

QuiltMC / quilt-loader

The loader for Quilt mods.
Apache License 2.0
470 stars 86 forks source link

Allowed the GameProvider to provide the namespace #428

Closed coolGi69 closed 4 months ago

coolGi69 commented 4 months ago

This PR adds a new optional function to the GameProvider called getNamespace to allow it to provide the namespace of the current session (which should be either be "named" or "intermediary").\ It also exposes the namespace to the GamePatch allowing it to be passed as an argument to it.

This PR also removes these lines in TinyFDPatch as (to the best of my knowledge), it will always return false (launcher.getMappingConfiguration().getTargetNamespace() and QuiltLoader.getMappingResolver().getNamespaces() are always the same), unless something went wrong (where the namespace is called something other than "named" or "intermediary"). Reverted this change as it will be needed for the planned hashed mappings/namespace (https://github.com/QuiltMC/quilt-loader/pull/428#discussion_r1590394769)

coolGi69 commented 4 months ago

@AlexIIL not sure if I should have notified you around 2 days ago when I made the commit, but those suggestions have been implemented in the most recent commit.\ Hopefully that should be all, but do tell me if there is anything else that needs to be changed.

Edit: Turns out there is a request for re-review button on GH that I missed, sry about that.