search

QuiltMC / quilt-loom

MIT License
22 stars 19 forks source link

RunConfig is never patched, creating invalid run configs #13

Closed triphora closed 2 years ago

triphora commented 2 years ago

net/fabricmc/loom/configuration/ide/RunConfig.java never is patched, creating invalid run configs, for example:

<component name="ProjectRunConfigurationManager">
  <configuration default="false" name="Minecraft Client" type="Application" factoryName="Application">
    <option name="MAIN_CLASS_NAME" value="net.fabricmc.devlaunchinjector.Main" />
    <module name="purpeille.main" />
    <option name="PROGRAM_PARAMETERS" value="" />
    <option name="VM_PARAMETERS" value="-Dfabric.dli.config=/home/acikek/Desktop/Projects/java/Mods/purpeille/.gradle/quilt-loom-cache/launch.cfg -Dfabric.dli.env=client -Dfabric.dli.main=net.fabricmc.loader.launch.knot.KnotClient" />
    <option name="WORKING_DIRECTORY" value="$PROJECT_DIR$/run/" />
    <method v="2">
      <option name="Make" enabled="true" />
    </method>
  </configuration>
</component>

A valid one should look something like this:

<component name="ProjectRunConfigurationManager">
  <configuration default="false" name="Minecraft Client" type="Application" factoryName="Application">
    <option name="MAIN_CLASS_NAME" value="net.fabricmc.devlaunchinjector.Main" />
    <module name="purpeille.main" />
    <option name="PROGRAM_PARAMETERS" value="" />
    <option name="VM_PARAMETERS" value="-Dfabric.dli.config=/home/acikek/Desktop/Projects/java/Mods/purpeille/.gradle/quilt-loom-cache/launch.cfg -Dfabric.dli.env=client -Dfabric.dli.main=org.quiltmc.loader.impl.launch.knot.KnotClient" />
    <option name="WORKING_DIRECTORY" value="$PROJECT_DIR$/run/" />
    <method v="2">
      <option name="Make" enabled="true" />
    </method>
  </configuration>
</component>
triphora commented 2 years ago

Turns out this is actually incorrect -- the original should work fine, it's a different issue entirely being encountered