search

QuiltMC / quilt-mappings

Quilt's Mappings for Minecraft
Creative Commons Zero v1.0 Universal
96 stars 76 forks source link

A lot of new classes #565

Closed pyrox0 closed 6 months ago

pyrox0 commented 6 months ago

Pulls a lot of datafixer classes in. I also took the chance to look through all of n/m/unmapped and map any class names that I could. This drops the number of classes in unmapped from 367 to 287, according to enigma's mapping stats. There's also a few other mappings I thought would be good to have in here, the main part being mapping ~92%~ of n/m/util/profiling.

ix0rai commented 6 months ago

great work, we love to see unmapped classes going down! will review sometime today

pyrox0 commented 6 months ago

Not necessarily something for this PR, but the suffixes for LootFunction sub-classes are a bit inconsistent. Most have LootFunction, a few have Function. I'd prefer no suffix for the non-abstract sub-classes because their verb-prefixed names already imply their function-ness.

I can do this in a later PR.

pyrox0 commented 6 months ago

All suggestions added!

pyrox0 commented 6 months ago

Forgot to actually push the above mentioned change, just did so.

ix0rai commented 6 months ago

just an aside: bootstrap context was indeed the old name. it's passed to static methods in worldgen classes to register their features and structures. I'd add an automap rule for net/minecraft/unmapped/C_hqoyyfco to context in simple_type_field_names.json5

pyrox0 commented 6 months ago

Added that!