QuiltMC / quilt-mappings

Quilt's Mappings for Minecraft
Creative Commons Zero v1.0 Universal
96 stars 76 forks source link

Renaming `ThreadedAnvilChunkStorage` #6

Closed Leo40Git closed 1 year ago

Leo40Git commented 3 years ago

I have 2 problems with TACS' current name:

  1. Anvil - this class does not deal with the Anvil chunk format at all! That's handled by ChunkSerializer.
  2. Storage - this class is actually a chunk manager, not just storage!

Additionally, there's the field that stores an instance of TACS in ServerChunkManager. You'll never guess what it's called... and ServerChunkManager delegates most of its actions to this instance (see my 2nd point)!

Therefore, I propose:

ix0rai commented 1 year ago

is there any reason no one has ever made another pr for this change?

Leo40Git commented 1 year ago

beyond me being too lazy, no