This contains a couple refactors:
NetworkState -> NetworkPhase -- we already refer to the different protocol phases as "phases" elsewhere in the code, this was an outlier.
ConnectionPhase (and affiliated classes) -> NetworkPhaseProtocol -- Had to be renamed to not clash confusingly with NetworkPhase. NetworkPhaseProtocol represents the serde for all the individual packets that make up the protocol of the phase. This distinction isn't made by Mojang (they actually just call everything the "protocol" and use ConnectionProtocol in lieu of what I'm calling NetworkPhase) but it seems to fit with how the code is structured.
This contains a couple refactors:
NetworkState->NetworkPhase-- we already refer to the different protocol phases as "phases" elsewhere in the code, this was an outlier.ConnectionPhase(and affiliated classes) ->NetworkPhaseProtocol-- Had to be renamed to not clash confusingly withNetworkPhase.NetworkPhaseProtocolrepresents the serde for all the individual packets that make up the protocol of the phase. This distinction isn't made by Mojang (they actually just call everything the "protocol" and useConnectionProtocolin lieu of what I'm callingNetworkPhase) but it seems to fit with how the code is structured.