search

QuiltMC / quilt-standard-libraries

A set of libraries to assist in making Quilt mods.
Apache License 2.0
152 stars 85 forks source link

Latest qfapi crashes Modpack. #224

Open netcore10 opened 1 year ago

netcore10 commented 1 year ago

I had to downgrade QFAPI to beta 19 / QSL, but i worry mods will start requiring later versions of qfapi/QSL.

Sent to both parties (a mod mentioned) because I don't know the fault.

https://mclo.gs/gqx8z98

magneticflux- commented 1 year ago

Conflicting mixins:

https://github.com/QuiltMC/quilt-standard-libraries/blob/8e361541dfe3fa6977b5cdae9e38f5062c7b685b/library/entity/status_effect/src/main/java/org/quiltmc/qsl/entity/effect/mixin/LivingEntityMixin.java#L141-L148

https://github.com/Ladysnake/Requiem/blob/44ba13e6e29aa93d73dc7aad0b6f4e4ebc247b97/requiem-core/src/main/java/ladysnake/requiem/core/mixin/possession/possessed/PossessableLivingEntityMixin.java#L335-L349

netcore10 commented 1 year ago

Requiem seems to have gone a bit MIA. I assume this can't be fixed on quilted end? I don't want to bog up your issues page.

netcore10 commented 1 year ago

Requiem seems to have gone a bit MIA. I assume this can't be fixed on quilted end? I don't want to bog up your issues page.

It did work on older Qfapi's, but i assume something changed internally.

LambdAurora commented 1 year ago

What change is the addition of the status effects API that introduces APIs related to status effect removal. Our mixin rewrite the method, and actually fixes the thing Requiem tries to fix itself, but due to the nature of those two mixins they are incompatible and I don't think we can fix this on our side.

netcore10 commented 1 year ago

That's fair enough. Luckily i'm sticking with these mods only, so for now i'll just stick with an older Qfapi until i'm forced to ditch requiem.