QuiltMC / quilt-standard-libraries

A set of libraries to assist in making Quilt mods.
Apache License 2.0
152 stars 85 forks source link

QSL 4.0.0-beta.12 and above incompatible with Enhanced Block Entities #279

Closed FoundationGames closed 1 year ago

FoundationGames commented 1 year ago

The GroupResourcePack flattening change introduced a redirect which replaces EBE's inject target for adding its own resources directly after vanilla EBE - LifecycledResourceManagerImplMixin QSL - MultiPackResourceManagerMixin

This results in EBE's resource packs never being applied when using QSL versions 4.0.0 beta 12 and above, as shown in EnhancedBlockEntities#136

LambdAurora commented 1 year ago

Fix is incoming as I found out that @ModifyVariable modifies locals which I did not understand prior to a discussion. Which allows me to make the QSL injection much much better.

Though, in the process of debugging I found out an issue in EBE itself, INVOKE_ASSIGN makes it so the injected pack is not present in the packs field of the class, using INVOKE instead should fix it. This is very important because QSL may recompute namespaces and it could lead to the pack being voided.