search

QuiltMC / quilt-standard-libraries

A set of libraries to assist in making Quilt mods.
Apache License 2.0
152 stars 85 forks source link

QSL's handling of builtin resource packs conflicts with Fabric API #322

Open EnnuiL opened 1 year ago

EnnuiL commented 1 year ago

With fabric#3164 allowing builtin resource pack extensions to override vanilla textures, we've got into a situation where we have two intentional behavior conflict with each other, which could theoretically be solved by a mixin on QFAPI's side but effectively? it would make QSL's behavior barely appear in practice;

In order to avoid a change on that area, I'd advocate for expanding the support for builtin resource pack extensions by having any resource pack be able to have such folders inside, in order to primarily allow builtin mod resource packs to modify vanilla Programmer's Art and High Contrast textures, since I believe having the mod itself attempt to override the vanilla textures without a builtin mod resource pack is bad practice due to how you can barely do anything about it and its potential to break stuff

Other than that? I believe that there's no other option but to flip the boolean in order to prevent breaking Fabric mods

LambdAurora commented 1 year ago

I don't like it but given Sodium needs it, then we'll change.

EnnuiL commented 1 year ago

That's the thing: if we managed to make so Sodium would have to make a separate on-by-default pack with the programmer_art folder being supported there? We could avoid this situation; well, at least if fabric ends copying us on that aspect;

LambdAurora commented 1 year ago

No, that's a shit solution.

It overcomplexify everything for no good.

EnnuiL commented 1 year ago

fair enough